Fix array validation 63/15763/3
authorRobert Varga <rovarga@cisco.com>
Thu, 26 Feb 2015 06:12:03 +0000 (07:12 +0100)
committerRobert Varga <rovarga@cisco.com>
Thu, 26 Feb 2015 07:59:25 +0000 (08:59 +0100)
commit1a04ff2a0ca5333a0712d2bd497fb90b9b99919f
tree9b0d583029afaf30b2dc30641b424db581dbfae5
parent1ef225ddeed34c62e37e596aead4921c4c26af25
Fix array validation

BGP unit tests show up a failure involving byte[] keys:

org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.valid.DataValidationException$IllegalListKeyException: Illegal value for key: (urn:opendaylight:params:xml:ns:yang:bgp-linkstate?revision=2015-02-10)route-key, in: (urn:opendaylight:params:xml:ns:yang:bgp-linkstate?revision=2015-02-10)linkstate-route[{(urn:opendaylight:params:xml:ns:yang:bgp-linkstate?revision=2015-02-10)route-key=[B@6e685e6c}], actual value: [B@5b0902b4, expected value from key: [B@6e685e6c
        at org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.valid.DataValidationException.checkListKey(DataValidationException.java:60)
        at org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableMapEntryNodeBuilder.checkKeys(ImmutableMapEntryNodeBuilder.java:101)
        at org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableMapEntryNodeBuilder.build(ImmutableMapEntryNodeBuilder.java:94)
        at org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableMapEntryNodeBuilder.build(ImmutableMapEntryNodeBuilder.java:22)
        at org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNormalizedNodeStreamWriter.endNode(ImmutableNormalizedNodeStreamWriter.java:129)
        at org.opendaylight.yangtools.binding.data.codec.impl.BindingToNormalizedStreamWriter.endNode(BindingToNormalizedStreamWriter.java:89)
        at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.linkstate.rev150210.linkstate.routes.linkstate.routes.LinkstateRoute$StreamWriter.serialize(DataObjectSerializerPrototype.java)
        at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry$DataObjectSerializerProxy.serialize(BindingNormalizedNodeCodecRegistry.java:273)
        at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry.toNormalizedNode(BindingNormalizedNodeCodecRegistry.java:99)
        at org.opendaylight.controller.md.sal.binding.impl.BindingToNormalizedNodeCodec.toNormalizedNode(BindingToNormalizedNodeCodec.java:56)

This boils down to how we compare the objects. Using Objects.equals() does
not cover arrays. Switching to deepEquals() solves the problem.

Change-Id: I725dbfca2af11e5b7c6213a8f650109383f13af8
Signed-off-by: Robert Varga <rovarga@cisco.com>
yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/valid/DataValidationException.java