Expose property name when checking key components 80/93180/3
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 19 Oct 2020 13:39:51 +0000 (15:39 +0200)
committerRobert Varga <nite@hq.sk>
Sat, 24 Oct 2020 17:20:30 +0000 (17:20 +0000)
commit1ee8e403b9c9eb9e8596b5e89cc5ed47676eb71c
treef4b3156ecd2d47becdd4cdcd3b958f378ce0e933
parent20097bfa551a01bb0013611edac4e04542c17f47
Expose property name when checking key components

Experience with null enforcement of key components indicates we should
carry the name of the property in the exception message -- otherwise
the string is not really helpful.

This patch re-organizes the checking so that we do that, via
newly-introduced CodeHelpers.requireKeyProp() method.

Since we are in the area, also codegen methods' handling of arrays by
creating an explicit 'cloneCall()' utility method.

JIRA: MDSAL-599
Change-Id: If9a87b4976ecdcd09e1fdd83ddfaf03ab4d09a85
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/BaseTemplate.xtend
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/ClassTemplate.xtend
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/JavaFileTemplate.java
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/ListKeyTemplate.xtend
binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/CodeHelpers.java