Refactor OVSDB Neutron Code 70/9170/10
authorDave Tucker <djt@redhat.com>
Thu, 17 Jul 2014 00:07:53 +0000 (01:07 +0100)
committerDave Tucker <djt@redhat.com>
Wed, 23 Jul 2014 00:30:28 +0000 (01:30 +0100)
commit33f98040c02e399b7891e12ffacdb2f5a0a8538c
tree0d6def86bd6e994c006f95894c471e4b09104960
parent7f694b634916401199e4ee1df7b9feb029e3bfe1
Refactor OVSDB Neutron Code

- Any OSGi Service that implements the NetworkingProvider interface is
  available as a Neutron Networking Provider
- OFXProvider is now resolved based on the version on OVS installed on
  the bridge
- Bump version to 1.0.0
- Refactor main service classes and add Javadocs
- Adjust class naming to better reflect purpose
- Move constants and utils to specialized classes
- Split api and implementation
- Expose neutron services via OSGi
- Move providers to a seperate bundle
- Clean up Activator
- Remove ServiceHelper and instead rely on OSGi Service Registry
- Remove unnecessary OSGi Lifecycle Callbacks
- Use Guava to create new HashMaps and Lists
- Use Guava Preconditions in place of null checks
- Fix bug in OVSDB plugin where OF Controllers and Protocols where not
  set in OVS < 1.10.0
- Export the "lib.errors" package from the OVSDB library

Change-Id: If197f04b94acc8811ee925f5d0892792e13adbb6
Signed-off-by: Dave Tucker <djt@redhat.com>
54 files changed:
commons/integrationtest/pom.xml
commons/parent/pom.xml
distribution/opendaylight/pom.xml
integrationtest/pom.xml
integrationtest/src/test/java/org/opendaylight/ovsdb/integrationtest/ConfigurationBundles.java
integrationtest/src/test/java/org/opendaylight/ovsdb/integrationtest/neutron/NeutronIT.java [new file with mode: 0644]
library/pom.xml
neutron/src/main/java/org/opendaylight/ovsdb/neutron/Activator.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/AdminConfigManager.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/BaseHandler.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/IAdminConfigManager.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/IInternalNetworkManager.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/ITenantNetworkManager.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/InternalNetworkManager.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/NodeConfiguration.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/TenantNetworkManager.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/provider/IProviderNetworkManager.java [deleted file]
neutron/src/main/java/org/opendaylight/ovsdb/neutron/provider/ProviderNetworkManager.java [deleted file]
neutron/src/test/java/org/opendaylight/ovsdb/neutron/AdminConfigManagerTest.java [deleted file]
neutron/src/test/java/org/opendaylight/ovsdb/neutron/BaseHandlerTest.java [deleted file]
neutron/src/test/java/org/opendaylight/ovsdb/neutron/NetworkHandlerTest.java [deleted file]
openstack/net-virt-providers/pom.xml [new file with mode: 0644]
openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/Activator.java [new file with mode: 0644]
openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/MdsalConsumer.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/IMDSALConsumer.java with 85% similarity]
openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/MdsalConsumerImpl.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/MDSALConsumer.java with 77% similarity]
openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/OF10Provider.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/provider/OF10Provider.java with 68% similarity]
openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/OF13Provider.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/provider/OF13Provider.java with 91% similarity]
openstack/net-virt/pom.xml [moved from neutron/pom.xml with 54% similarity]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/AbstractHandler.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/Activator.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/NetworkHandler.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/NetworkHandler.java with 85% similarity]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/NodeConfiguration.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/PortHandler.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/PortHandler.java with 85% similarity]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/PortSecurityHandler.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/PortSecurityHandler.java with 97% similarity]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/SouthboundEvent.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/SouthboundEvent.java with 98% similarity]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/SouthboundHandler.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/SouthboundHandler.java with 85% similarity]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/SubnetHandler.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/SubnetHandler.java with 91% similarity]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/BridgeConfigurationManager.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/ConfigurationService.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/Constants.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/NetworkingProvider.java [moved from neutron/src/main/java/org/opendaylight/ovsdb/neutron/provider/NetworkProvider.java with 71% similarity]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/NetworkingProviderManager.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/TenantNetworkManager.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/UuidUtils.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/VlanConfigurationCache.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/BridgeConfigurationManagerImpl.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/ConfigurationServiceImpl.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/ProviderNetworkManagerImpl.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/TenantNetworkManagerImpl.java [new file with mode: 0644]
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/VlanConfigurationCacheImpl.java [new file with mode: 0644]
openstack/net-virt/src/test/java/org/opendaylight/ovsdb/openstack/netvirt/UuidUtilsTest.java [new file with mode: 0644]
plugin/pom.xml
plugin/src/main/java/org/opendaylight/ovsdb/plugin/ConfigurationService.java
pom.xml