Fix findbugs violations in library 36/69036/8
authorTom Pantelis <tompantelis@gmail.com>
Sat, 3 Mar 2018 15:16:49 +0000 (10:16 -0500)
committerTom Pantelis <tompantelis@gmail.com>
Mon, 12 Mar 2018 22:27:18 +0000 (18:27 -0400)
commit378aafd8e77feaaefb6b95866c53dd81f0afab67
treedb5c90457c78947d63de56b51db2660fa18536a6
parentd3817c125a501becbe87dba14f33cbe2a3b911ea
Fix findbugs violations in library

- Possible null pointer dereference
- Equals method should not assume anything about the type of its argument
- Method ignores exceptional return value
- Equals checks for incompatible operand
- Unusual equals method
- Class is Serializable, but doesn't define serialVersionUID
- Consider using Locale parameterized version of invoked method
- Field isn't final but should be
- Incorrect lazy initialization of static field
- Inefficient use of keySet iterator instead of entrySet iterator
- Should be a static inner class
- Boxing/unboxing to parse a primitive
- Unread field
- Return value of method without side effect is ignored
- Write to static field from instance method
- Load of known null value

Change-Id: I5f7ae7b280919d2f1cfcd86be41cab5d8370a752
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
17 files changed:
.gitignore
hwvtepsouthbound/hwvtepsouthbound-impl/src/test/java/org/opendaylight/ovsdb/hwvtepsouthbound/DataChangeListenerTestBase.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/MonitorHandle.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/impl/OvsdbConnectionService.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/impl/StalePassiveConnectionService.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/Version.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/OvsdbMapSerializer.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/OvsdbTypesIdResolver.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/operations/Mutate.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/operations/Operations.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/operations/Update.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/schema/typed/TyperUtils.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/OpenVSwitchBridgeAddCommandTest.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/OvsdbNodeUpdateCommandTest.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/ProtocolUpdateCommandTest.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/TerminationPointUpdateCommandTest.java