Code Review / netconf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 41d58dd) | patch
Release the buffer only after we are done with it 83/77083/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 18 Oct 2018 15:25:55 +0000 (17:25 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 18 Oct 2018 15:27:33 +0000 (17:27 +0200)
commit3b2eedf1db47e64e761e2bb366842dc1a43d2630
tree7be12d158e3ef687c6375e0b663181adf14d6063tree | snapshot
parent41d58dd49ba261e14ce1d556f46ecce30bb7e973commit | diff
Release the buffer only after we are done with it

We may end up touching the buffer after we have release()'d it,
which means it may have been recycled by the time we call
resetReaderIndex().

Move the release() call to after the check so we do not end up
releasing it prematurely.

Change-Id: I43156dbe2e6c53a552a322e7b5ea27f8da3873c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/handler/ssh/client/AsyncSshHandlerWriter.java diff | blob | history
Netconf