Code Review / odlguice.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 82bb6cc) | patch
Fix broken GuiceModule, and rename it to AbstractGuiceJsr250Module
authorMichael Vorburger <vorburger@redhat.com>
Mon, 10 Oct 2016 11:40:01 +0000 (13:40 +0200)
committerMichael Vorburger <vorburger@redhat.com>
Mon, 10 Oct 2016 11:40:01 +0000 (13:40 +0200)
commit5192a679ad6740b44afe03b150b5e9c4d425c0e1
tree67850788e7caa254815348976d1bb4da40fb8d58tree | snapshot
parent82bb6cc0653ad61581adaa3f4822b0d41dc5484ecommit | diff
Fix broken GuiceModule, and rename it to AbstractGuiceJsr250Module

Bug: final configure() forgot to call the abstract configureBindings()

The self test has also been improved to actually detect this problem.
(Before it was too simplistic; without an interface, there was actually
no need at all for a binding, so the problem went undetected.)

Change-Id: I25ff3ccfb84d4179e50befd898e4e911d854f795
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
inject-guice-testutils/src/main/java/org/opendaylight/infrautils/inject/guice/testutils/AbstractGuiceJsr250Module.java [moved from inject-guice-testutils/src/main/java/org/opendaylight/infrautils/inject/guice/testutils/GuiceModule.java with 89% similarity] diff | blob | history
inject-guice-testutils/src/test/java/org/opendaylight/infrautils/inject/guice/testutils/tests/ExampleGuiceRuleTest.java diff | blob | history
inject-guice-testutils/src/test/java/org/opendaylight/infrautils/inject/guice/testutils/tests/SomeClassWithPostConstruct.java diff | blob | history
inject-guice-testutils/src/test/java/org/opendaylight/infrautils/inject/guice/testutils/tests/SomeInterfaceWithPostConstruct.java [new file with mode: 0644] blob
odlguice - archived