Sonar clean-ups 67/26767/1
authorStephen Kitt <skitt@redhat.com>
Thu, 10 Sep 2015 12:40:14 +0000 (14:40 +0200)
committerStephen Kitt <skitt@redhat.com>
Thu, 10 Sep 2015 12:54:25 +0000 (14:54 +0200)
commit5830ff09f1d8ef282b430ba12eb3494104e32013
tree19d64d40ef06bf21e065c923d276ac0bc356c883
parent03e3f596a4f51447d5c6ec0f640622f9f3c39524
Sonar clean-ups

Starting from source files containing collapsible ifs:
* merge collapsible ifs;
* remove unused parameters;
* remove unused exceptions;
* remove unused fields;
* rename shadowing variables;
* add private constructors for utility classes;
* use more specific exceptions than RuntimeException;
* clean up "if () return true; else return false;";
* some Java 7 <> operators;
* add missing "static" for constants;
* remove unused private methods (except in OF13Provider);
* move some inline comments above the corresponding source line;
* used boolean instead of Boolean for Map::contains();
* replace foreach-style constructs examining the first element only
  with explicit "if (...hasNext()) ... = ... next()";
* prohibit overriding methods called from constructors;
* remove useless casts.

Reverse the order of node augmentation handling in SouthboundUtil so
that the augmentation case can actually trigger.

Change-Id: Ie4fc662bdcc0e2133fdd4f57b783723466b1f2a9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
20 files changed:
library/impl/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcDecoder.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/ConditionSerializer.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/Converter.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/MutationSerializer.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/OvsdbMapSerializer.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/OvsdbSetSerializer.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/RowSerializer.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/UUIDSerializer.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/schema/ColumnSchema.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/schema/ColumnType.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/schema/typed/TyperUtils.java
northbound/src/main/java/org/opendaylight/ovsdb/northbound/OvsdbRow.java
openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/OF13Provider.java
openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/PipelineOrchestratorImpl.java
openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/services/arp/GatewayMacResolverService.java
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/SouthboundHandler.java
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/BridgeConfigurationManagerImpl.java
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/NeutronL3Adapter.java
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/SecurityServicesImpl.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/SouthboundUtil.java