Bug 6692: clean up MonitorRequestBuilder 52/44952/2
authorStephen Kitt <skitt@redhat.com>
Wed, 31 Aug 2016 16:36:58 +0000 (18:36 +0200)
committerStephen Kitt <skitt@redhat.com>
Mon, 12 Sep 2016 09:08:52 +0000 (09:08 +0000)
commit5de7b5c4365b407998a78e04ba81ee0ac80b207b
treed6bb52a56b6aacdd14bc5eaf4912e9570e85cf9d
parentb31022fb52f726da3553e45289d832ca25be391c
Bug 6692: clean up MonitorRequestBuilder

MonitorRequest can't be made immutable, so the utility of this builder
is to support fluent-style construction and addColumns() with multiple
columns. This patch removes unneeded methods from MonitorRequest,
drops the static builder() in favour of the constructor, adds support
for addColumns() with multiple strings, and constructs a new instance
for every call to build(). It also performs the skip cleanup in one
step instead of looping over the columns.

Change-Id: I89fd8a554551c3142efc82dbf6bb43417c6148ae
Signed-off-by: Stephen Kitt <skitt@redhat.com>
hwvtepsouthbound/hwvtepsouthbound-impl/src/main/java/org/opendaylight/ovsdb/hwvtepsouthbound/HwvtepConnectionInstance.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/message/MonitorRequest.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/message/MonitorRequestBuilder.java
library/it/src/test/java/org/opendaylight/ovsdb/integrationtest/ovsdbclient/OvsdbClientTestIT.java
library/it/src/test/java/org/opendaylight/ovsdb/lib/it/LibraryIntegrationTestBase.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionInstance.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionInstanceTest.java