improve error logs due to IllegalArgumentException to include full input 71/76771/4
authorMichael Vorburger <vorburger@redhat.com>
Mon, 8 Oct 2018 21:59:37 +0000 (23:59 +0200)
committerMichael Vorburger <vorburger@redhat.com>
Tue, 30 Oct 2018 18:06:48 +0000 (19:06 +0100)
commit62672557e49d8c29b5552a4b87d7e6ca99062983
treed6bb4f287993e6413f5560721df32a08dc276611
parentce8da97340debf2a334e8d5bdbda5819e4f3e0cc
improve error logs due to IllegalArgumentException to include full input

This requires, and adds, a working toString() for all *Request classes,
which is always useful for future logging of requests elsewhere.

This introduction of a NeutronRequest (an ABC instead of an interface)
could in the future also allow a follow-up change to get rid of the
reflection in INeutronRequest, by having a (generic) "singleton" and a
"bulkRequest" field in NeutronRequest instead of in each *Request class.
(The problem with that idea, and why it is how it currently is, are the
@XmlElement annotations for singleton and bulkRequest in each *Request;
those would have to be moved to new getters.)

Change-Id: I9769a3825632dd2bd2f9e2875b91d06a4f781616
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
35 files changed:
integration/test-standalone/src/main/java/org/opendaylight/neutron/e2etest/HttpUtils.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/AbstractNeutronNorthbound.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronBgpvpnRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFirewallPolicyRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFirewallRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFirewallRuleRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronFloatingIpRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronL2gatewayConnectionRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronL2gatewayRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerHealthMonitorRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerListenerRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerPoolMemberRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerPoolRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronLoadBalancerRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronMeteringLabelRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronMeteringLabelRuleRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronNetworkRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronPortRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronQosPolicyRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronRequest.java [new file with mode: 0644]
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronRouterRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCFlowClassifierRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCPortChainRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCPortPairGroupRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSFCPortPairRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSecurityGroupRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSecurityRuleRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronSubnetRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronTapFlowRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronTapServiceRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronTrunkRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnIkePolicyRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnIpSecPolicyRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnIpSecSiteConnectionRequest.java
northbound-api/src/main/java/org/opendaylight/neutron/northbound/api/NeutronVpnServiceRequest.java