Code Review / openflowplugin.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 70d610f) | patch
Fix findbugs violations in extensions 88/68388/3
authorTom Pantelis <tompantelis@gmail.com>
Sun, 18 Feb 2018 18:37:10 +0000 (13:37 -0500)
committerTom Pantelis <tompantelis@gmail.com>
Wed, 28 Feb 2018 18:45:18 +0000 (13:45 -0500)
commit64d904831f34c15e17df2b6adc4611c1b0fa6892
tree926fda393f7d55d6bf44500317ab76c9a7c9acfftree | snapshot
parent70d610fe3f0da58be0c5cd8d6b16d01dde99b686commit | diff
Fix findbugs violations in extensions

- Dead store to local variable
- Unchecked/unconfirmed cast
- Field not initialized in constructor but dereferenced without null check
- Method ignores return value
- Private method is never called

Change-Id: I7a3fe1700439b456cb7dce6d84f63a9840fd68a7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
extension/openflowjava-extension-nicira/src/main/java/org/opendaylight/openflowjava/nx/codec/action/PopNshCodec.java diff | blob | history
extension/openflowjava-extension-nicira/src/main/java/org/opendaylight/openflowjava/nx/codec/action/PushNshCodec.java diff | blob | history
extension/openflowplugin-extension-api/src/main/java/org/opendaylight/openflowplugin/extension/api/GroupingLooseResolver.java diff | blob | history
extension/openflowplugin-extension-nicira/src/main/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/PopNshConvertor.java diff | blob | history
extension/openflowplugin-extension-nicira/src/main/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/PushNshConvertor.java diff | blob | history
extension/openflowplugin-extension-onf/src/main/java/org/opendaylight/openflowplugin/extension/onf/deserializer/BundleControlFactory.java diff | blob | history
extension/test-extension/pom.xml diff | blob | history
extension/test-extension/src/main/java/org/opendaylight/openflowplugin/extension/test/Test.java diff | blob | history
OpenFlow Plugin