Code Review / yangtools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 3fc71c3) | patch
YANGTOOLS-724: mark leaking fields 06/65406/1
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 10 Nov 2017 10:12:53 +0000 (11:12 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Fri, 10 Nov 2017 10:25:14 +0000 (11:25 +0100)
commit65f8b36626492c04740a9756f5e6f53b5fdcabda
tree3bfcec8293c3917e2db31728a5c7c2cc18d99f84tree | snapshot
parent3fc71c3c18aafb7010c4cb5af42c6af63c89de59commit | diff
YANGTOOLS-724: mark leaking fields

Lifecycle of 'augmenting' is wrong here, as we are resetting
this field after the effective statement has been built.

This indicates that the constructor is not getting enough/accurate
information about what is going on -- which is something we will
need to fix at some point.

Mark both occurances of this field, make the fields private and
expose a resetAugmenting() method.

Change-Id: Ica2678e885b624c850959fea21ee6120cfbd9da6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/effective/AbstractEffectiveDataSchemaNode.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/effective/AbstractEffectiveSimpleDataNodeContainer.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/effective/ChoiceEffectiveStatementImpl.java diff | blob | history
OpenDaylight YANG Tools