Code Review / openflowplugin.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 9adf5db) | patch
Fix findbugs violations in samples 83/68383/2
authorTom Pantelis <tompantelis@gmail.com>
Sat, 17 Feb 2018 23:31:07 +0000 (18:31 -0500)
committerTom Pantelis <tompantelis@gmail.com>
Wed, 28 Feb 2018 18:45:18 +0000 (13:45 -0500)
commit70d610fe3f0da58be0c5cd8d6b16d01dde99b686
treec324064b7e87ce60b60bb09aa10a7264bb0139e5tree | snapshot
parent9adf5db88907bb31fca34219090961f3c523d970commit | diff
Fix findbugs violations in samples

- Inconsistent synchronization
- Using notify() rather than notifyAll()
- Method ignores return value
- Read of unwritten field
- Field not initialized in constructor but dereferenced without null check

Change-Id: I12e8ae3ab25cc41ba05b99e9e4c85f2606a2814d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
samples/learning-switch/pom.xml diff | blob | history
samples/learning-switch/src/main/java/org/opendaylight/openflowplugin/learningswitch/LearningSwitchHandler.java diff | blob | history
samples/learning-switch/src/main/java/org/opendaylight/openflowplugin/learningswitch/LearningSwitchHandlerSimpleImpl.java diff | blob | history
samples/learning-switch/src/main/java/org/opendaylight/openflowplugin/learningswitch/LearningSwitchManagerSimpleImpl.java diff | blob | history
samples/learning-switch/src/main/java/org/opendaylight/openflowplugin/learningswitch/multi/LearningSwitchManagerMultiImpl.java diff | blob | history
samples/learning-switch/src/main/java/org/opendaylight/openflowplugin/learningswitch/multi/MultipleLearningSwitchHandlerFacadeImpl.java diff | blob | history
samples/sample-consumer/src/main/java/org/opendaylight/openflowplugin/openflow/samples/consumer/Activator.java diff | blob | history
samples/sample-consumer/src/main/java/org/opendaylight/openflowplugin/openflow/samples/consumer/SimpleDropFirewall.java diff | blob | history
samples/sample-consumer/src/main/java/org/opendaylight/openflowplugin/openflow/samples/consumer/SimpleDropFirewallCli.java diff | blob | history
samples/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ScenarioHandler.java diff | blob | history
OpenFlow Plugin