Code Review / yangtools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 6e94a61) | patch
YANGTOOLS-827: fix revision compare 80/65280/1
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 7 Nov 2017 18:28:53 +0000 (19:28 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Tue, 7 Nov 2017 18:36:38 +0000 (19:36 +0100)
commit7358320d8f419c5439dd0578f150c14936be5dae
treea63e0c5b1765af6e7051186ac78790c51e84982ctree | snapshot
parent6e94a61938980d1193e069bc5d5f78adbfd270cdcommit | diff
YANGTOOLS-827: fix revision compare

When revision statements do not follow guidance from RFC6020/RFC7950
section 7.1.9 and are not order in the order of descending date and
the delta between previous and next version strings is not exactly 1,
we end up picking the wrong version.

This is caused by wrong compareTo() check, which should compare '< 0',
not '== -1'.

Change-Id: Ib7f9a77a9950b6da93ffa30e4c13cc940887ad19
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3c855240dd70f79e7acd9fa98adb8c6a3580f60b)
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/impl/util/YangModelDependencyInfo.java diff | blob | history
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/impl/util/YangModelDependencyInfoTest.java diff | blob | history
yang/yang-parser-impl/src/test/resources/bugs/YT827/foo.yang [new file with mode: 0644] blob
OpenDaylight YANG Tools