Code Review / mdsal.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 29188c3) | patch
Do not use a static String reference in length enforcer 45/96345/1
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 21 May 2021 11:13:11 +0000 (13:13 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 24 May 2021 20:41:48 +0000 (22:41 +0200)
commit73bee685bbc9a8f59763293c15057df481dbdae2
treea7a54f95b47d16d5a7fd6b007c240eb1eb83cbcctree | snapshot
parent29188c323f86304a9ae1f7471c7c5d5a741eefb1commit | diff
Do not use a static String reference in length enforcer

LengthGenerator is making the mistake of having a static reference
to java.lang.String without FQCN. This breaks down if String is
overridden by definition context.

Fix this by using importedName(Type) to emit a properly-scoped
reference.

JIRA: MDSAL-664
Change-Id: I16b12865448bde807f0afd0d35e3145f8b6359c3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b07c63ce93a839e806c8ce96b8ef659e658574e3)
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/LengthGenerator.java diff | blob | history
binding/mdsal-binding-java-api-generator/src/test/java/org/opendaylight/mdsal/binding/java/api/generator/test/CompilationTest.java diff | blob | history
binding/mdsal-binding-java-api-generator/src/test/resources/compilation/mdsal664/foo.yang [new file with mode: 0644] blob
MD-SAL: Model-Driven Service Adaptation Layer