Fix findbugs violations in openflowplugin 91/68391/2
authorTom Pantelis <tompantelis@gmail.com>
Mon, 19 Feb 2018 01:56:48 +0000 (20:56 -0500)
committerTom Pantelis <tompantelis@gmail.com>
Wed, 28 Feb 2018 18:45:18 +0000 (13:45 -0500)
commit7430f77eb8bb34e38acb5a34e3ac634b690323f4
tree6eac18abae59806244a132d2d4aa74283172676a
parent64d904831f34c15e17df2b6adc4611c1b0fa6892
Fix findbugs violations in openflowplugin

- Comparison of String parameter using == or !=
- Comparator doesn't implement Serializable
- Field is a mutable collection
- Incorrect lazy initialization of static field
- Inefficient use of keySet iterator instead of entrySet iterator
- Private method is never called
- Unsigned right shift cast to short/byte
- Class is final but declares protected field
- Consider returning a zero length array rather than null

Change-Id: I714bd4005a33a772b0b76b0c0f89f28b8517cd06
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/match/AbstractMatchEntrySerializer.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/ConvertorManager.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/common/IpConversionUtil.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/common/OrderComparator.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/flow/FlowConvertor.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/sal/convertor/match/MatchConvertorUtil.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/core/session/ExtensionSessionManagerImpl.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/util/ActionUtil.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/util/ByteUtil.java
openflowplugin/src/main/java/org/opendaylight/openflowplugin/openflow/md/util/InventoryDataServiceUtil.java