OPNFLWPLUG-1090: ConcurrentModificationException: null when connecting cbench switches 12/89612/3
authorGobinath <gobinath@ericsson.com>
Wed, 6 May 2020 09:59:47 +0000 (15:29 +0530)
committerArunprakash D <d.arunprakash@ericsson.com>
Thu, 28 May 2020 07:20:21 +0000 (07:20 +0000)
commit7e23574d8a06556de55fac64bf1f3d82c4287c4d
tree27f933f7fb75a3a7f26ef7f3df5defad28fc1192
parent70c8a3e5aa986e001d48149f62aa910223ed1168
OPNFLWPLUG-1090: ConcurrentModificationException: null when connecting cbench switches

Issue:

CSIT job using cbench was frequently failing because some switches are
getting their initial connection rejected.

Observation and Fix:

On analyzing the logs it was found that the failure had been caused by
the sessionstats collection during initial handshake. "ConcurrentModification"
exception was thrown as multiple switch sessions were trying to modify
the SESSION_EVENTS map which reulted in the connection getting closed.

This has been fixed by making the SESSION_EVENTS threadsafe now.

Change-Id: I2d0ec7c00d7c893d6271942f5fdbe9815069d4d0
Signed-off-by: Gobinath <gobinath@ericsson.com>
(cherry picked from commit bd28cb92e0f6f3bca79a04a5e5a57c617b6cb552)
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/ofpspecific/SessionStatistics.java