Code Review / netconf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 400de56) | patch
Fix unsafe global config access 85/82185/1
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 21 May 2019 11:27:02 +0000 (13:27 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Tue, 21 May 2019 11:27:02 +0000 (13:27 +0200)
commit7ee9b76a0aec7084956068462ff02587fb195f4c
tree0d222aff165c0c4f5d539b1e72339220aa65e463tree | snapshot
parent400de56cb8b307eef46160e8d3ca134217964b13commit | diff
Fix unsafe global config access

Current global config is a volatile variable, hence it must be
acquired into a local variable for proper nullness checks --
otherwise it is open to TOCTOU race conditions leading to NPEs.

Change-Id: I9316b3ed976575726da7a065668c507e15fe0ddf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
netconf/callhome-provider/src/main/java/org/opendaylight/netconf/callhome/mount/CallHomeAuthProviderImpl.java diff | blob | history
Netconf