Code Review / ovsdb.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 5d8c3be) | patch
Do not use Foo.toString() when logging 01/85401/1
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 28 Oct 2019 07:25:36 +0000 (08:25 +0100)
committerRobert Varga <nite@hq.sk>
Mon, 28 Oct 2019 09:12:28 +0000 (09:12 +0000)
commit84efe1721637ffefc4f333da51898cfd145732c7
tree42460ec396f07a9fdb7b463af0f8d39cfb9b0e6etree | snapshot
parent5d8c3be421f016ab87129a75effcd3daf1e01ebccommit | diff
Do not use Foo.toString() when logging

This was spotted in a JFR run, where JsonRpcEndpoint would consume
a lot of CPU formatting a logging object. Eliminate calls to toString()
in logging arguments, as the framework will call these when really
needed.

Change-Id: Id077c285074c1fd8012539ab7c144ddc4b286376
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 10119331189066c009db4f0000a39ae586cc164c)
hwvtepsouthbound/hwvtepsouthbound-it/src/test/java/org/opendaylight/ovsdb/hwvtepsouthbound/it/HwvtepSouthboundIT.java diff | blob | history
library/impl/src/main/java/org/opendaylight/ovsdb/lib/impl/OvsdbConnectionService.java diff | blob | history
library/impl/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java diff | blob | history
library/it/src/test/java/org/opendaylight/ovsdb/integrationtest/ovsdbclient/OvsdbClientTestIT.java diff | blob | history
library/it/src/test/java/org/opendaylight/ovsdb/integrationtest/ovsdbclient/OvsdbClientTestTypedIT.java diff | blob | history
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbAutoAttachRemovedCommand.java diff | blob | history
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbQosRemovedCommand.java diff | blob | history
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbQueueRemovedCommand.java diff | blob | history
southbound/southbound-it/src/test/java/org/opendaylight/ovsdb/southbound/it/SouthboundIT.java diff | blob | history
Open vSwitch Database Management Protocol