Code Review / yangtools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 73276d2) | patch
BUG-1097: implemented check for null or empty list in builder classes. 20/9120/3
authorMartin Vitez <mvitez@cisco.com>
Thu, 17 Jul 2014 14:18:00 +0000 (16:18 +0200)
committerMartin Vitez <mvitez@cisco.com>
Mon, 21 Jul 2014 08:34:02 +0000 (10:34 +0200)
commit883ae26ee98953a5df7cc0956afa807a82d58a3a
tree966d4fa18702af88174f106420de41cef56b4341tree | snapshot
parent73276d20a41d17977e730e5bec623a35d3d7869fcommit | diff
BUG-1097: implemented check for null or empty list in builder classes.

If one of builder variable is List, do following:
 - for null value create Collections.emptyList()
 - for empty list create Collections.emptyList()
 - for any other list create ImmutableList.copyOf(<arg>)

Added test.

Change-Id: I83e5aaf4f4253aa2e195c23ff5b48b04fc883052
Signed-off-by: Martin Vitez <mvitez@cisco.com>
code-generator/binding-java-api-generator/src/main/java/org/opendaylight/yangtools/sal/java/api/generator/BuilderTemplate.xtend diff | blob | history
code-generator/binding-java-api-generator/src/test/java/org/opendaylight/yangtools/sal/java/api/generator/test/CompilationTest.java diff | blob | history
code-generator/binding-java-api-generator/src/test/resources/compilation/bug1097/foo.yang [new file with mode: 0644] blob
OpenDaylight YANG Tools