Fix findbugs violations in liblldp 86/67886/8
authorTom Pantelis <tompantelis@gmail.com>
Sat, 3 Feb 2018 01:43:09 +0000 (20:43 -0500)
committerTom Pantelis <tompantelis@gmail.com>
Wed, 28 Feb 2018 18:45:17 +0000 (13:45 -0500)
commit9adf5db88907bb31fca34219090961f3c523d970
tree1b8754524205ddf06deab8d39a6a7dbffd2a9fe8
parent8c8afa72bf93734ea40367e0831a571c037d5ca2
Fix findbugs violations in liblldp

- Method call passes null for non-null parameter
- Class defines clone() but doesn't implement Cloneable
- Clone method may return null
- clone method does not call super.clone()
- equals() method does not check for null argument
- Reliance on default encoding
- May expose internal representation by returning reference to mutable object
- Field is a mutable collection which should be package protected - malicious code vulnerability
- Field should be package protected - malicious code vulnerability
- Inefficient use of keySet iterator instead of entrySet iterator
- Boxing/unboxing to parse a primitive - use parseXXX method
- Redundant nullcheck of value known to be non-null

Change-Id: I6d551d31d618a1adfc877ac59f29d02727201df6
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
13 files changed:
applications/lldp-speaker/src/main/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPUtil.java
applications/topology-lldp-discovery/src/main/java/org/opendaylight/openflowplugin/applications/topology/lldp/utils/LLDPDiscoveryUtils.java
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/BitBufferHelper.java
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/ConstructionException.java [deleted file]
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/DataLinkAddress.java
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/EtherTypes.java
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/Ethernet.java
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/EthernetAddress.java
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDP.java
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/LLDPTLV.java
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/NetUtils.java
libraries/liblldp/src/main/java/org/opendaylight/openflowplugin/libraries/liblldp/Packet.java
libraries/liblldp/src/test/java/org/opendaylight/openflowplugin/libraries/sal/packet/address/EthernetAddressTest.java