Non ipv4 advertising peer causes BGP session flaps 33/91733/1
authorVikram Singh Kalakoti <vikramskalakoti@gmail.com>
Wed, 1 Jul 2020 19:04:08 +0000 (00:34 +0530)
committerRobert Varga <nite@hq.sk>
Mon, 3 Aug 2020 11:24:24 +0000 (11:24 +0000)
commitaa617da070cfd3168c2c430100a54fec4510d006
tree188555b31fe4138ba6cd28c442dd3c648e8fa035
parentc075b12c082e2ca6e9fc3a63492035b105462280
Non ipv4 advertising peer causes BGP session flaps

During the session establishment phase, if a peer
doesn't advertise ipv4-unicast, controller
automatically adds ipv4-unicast as supported
family for the session to support classic BGP
sessions.

Currently, we are adding Ipv4 family in the
BGPPeer but not updating AdjRibInWriter which
causes the BGP session to not recover from
session flap. Patch fixes this issue by adding
ipv4 support before updating AdjRibInWriter.

JIRA: BGPCEP-910
Change-Id: I669104a17d603e0494f9ac7090a8fd671f67a3a5
Signed-off-by: Vikram Singh Kalakoti <vikramskalakoti@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f54f4bd31f5ceb0a15edacb9b2884a63a21cb52d)
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPPeer.java
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/GracefulRestartTest.java