Fix: pre-commit and tox issues 51/106151/7
authorAnil Belur <abelur@linuxfoundation.org>
Thu, 25 May 2023 02:14:13 +0000 (12:14 +1000)
committerAnil Belur <abelur@linuxfoundation.org>
Fri, 26 May 2023 13:52:16 +0000 (23:52 +1000)
commitaecd269aec4873153ed7b5b8dd4b2f1c69d1a7f0
tree3ef1b071f74fa3e75be72916a13772dbbec27b2d
parent1c3f139a2b543f675c7528e27969bd4a65e06168
Fix: pre-commit and tox issues

pre-commit and tox issues need to be fixed for tox-verify
GHA tox-verify to work correctly.

- shellcheck errors:
  SC3040 (warning): In POSIX sh, set option pipefail is undefined.
  SC3037 (warning): In POSIX sh, echo flags are undefined.
  SC2086 (info): Double quote to prevent globbing and word splitting.
  SC2004 (style): $/${} is unnecessary on arithmetic variables.
- flake: E501 line too long
- pydocsytle errors:
  D103: Missing docstring in public function
  D100: Missing docstring in public module
- write-good errors remove passive voice
- Fixes bandit: CWE: CWE-20 (https://cwe.mitre.org/data/definitions/20.html)
  Using lxml.etree.parse to parse untrusted XML data is known to be
  vulnerable to XML attacks. Replace lxml.etree.parse with its
  defusedxml equivalent function
  Ref: https://rules.sonarsource.com/python/RSPEC-2755

Issue: LF-JIRA RELENG-4742
Change-Id: I635281bc39ebb1157df13dde6809c2809af8c1d4
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
15 files changed:
jjb/docs/docs-post-rtd.sh
jjb/integration/common-functions.sh
jjb/integration/integration-get-slave-addresses.sh
jjb/integration/integration-macros.yaml
jjb/lf-infra-releasedockerhub.yaml
jjb/opendaylight-infra-deploy-maven-site.sh
jjb/releng-maven-mri-stage.sh
jjb/releng-maven-mri-stage.yaml
jjb/run_releasedockerhub.sh
scripts/bump_mri_versions/main.py
scripts/bump_mri_versions/python_lib.py
scripts/bump_mri_versions/readme.md
scripts/delete-jobs.sh
scripts/rename-jobs.sh
tox.ini