Code Review / yangtools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: c01c735) | patch
YANGTOOLS-827: fix revision compare 78/65278/2
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 7 Nov 2017 18:28:53 +0000 (19:28 +0100)
committerRobert Varga <nite@hq.sk>
Tue, 7 Nov 2017 20:25:47 +0000 (20:25 +0000)
commitb8d22ce2dbaccdd7cef3acf3be398844e5531bcf
treef9f3f2093f4f45e139f04c030340754d587c51f7tree | snapshot
parentc01c7358505ba793b10bfccb81e1b77ca3992888commit | diff
YANGTOOLS-827: fix revision compare

When revision statements do not follow guidance from RFC6020/RFC7950
section 7.1.9 and are not order in the order of descending date and
the delta between previous and next version strings is not exactly 1,
we end up picking the wrong version.

This is caused by wrong compareTo() check, which should compare '< 0',
not '== -1'.

Change-Id: Ib7f9a77a9950b6da93ffa30e4c13cc940887ad19
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/impl/util/YangModelDependencyInfo.java diff | blob | history
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/impl/util/YangModelDependencyInfoTest.java diff | blob | history
yang/yang-parser-impl/src/test/resources/bugs/YT827/foo.yang [new file with mode: 0644] blob
OpenDaylight YANG Tools