Bug 3136: Delete output port from instruction should use order instead of index 97/19797/4
authorFlavio Fernandes <ffernand@redhat.com>
Thu, 7 May 2015 11:55:08 +0000 (20:55 +0900)
committerFlavio Fernandes <ffernand@redhat.com>
Wed, 13 May 2015 10:55:36 +0000 (06:55 -0400)
commitb98511004e9088cef54ffd0da08041bc45f533bf
tree84e1b39743f662ee3473a116439b2b6d47b1802f
parentda5e0332185578844fcecd0032c4d638e4fd1b4c
Bug 3136: Delete output port from instruction should use order instead of index

Added comments to better explain the impmlementation.

The removeOutputPortFromInstructions was implemented under the assumption that
list index and order of action are equal. This could lead to action list where
order is not rebuilt properly.

Also, if removing port is not found in action list, the implementation would
cause the removal of the flow; when in fact it should leave list as is.

Change-Id: Id42d592db52c83897fd731f3bbef0434cc83d435
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Also-By: shc411 <jung33@gmail.com>
utils/mdsal-openflow/src/main/java/org/opendaylight/ovsdb/utils/mdsal/openflow/InstructionUtils.java