do not explicit serialVersionUID anymore 58/93758/1
authorguillaume.lambert <guillaume.lambert@orange.com>
Tue, 22 Sep 2020 08:11:12 +0000 (10:11 +0200)
committerguillaume.lambert <guillaume.lambert@orange.com>
Tue, 10 Nov 2020 17:06:40 +0000 (18:06 +0100)
commitbae56bbc6e303cbf05395ec333dfd772d71e7613
treef28d174e960a1aab8097de5ade2a6dc65b243c9d
parent5d2ef1e86b227d0170d00d84fbd25d1ed1364623
do not explicit serialVersionUID anymore

A new SpotBug rule has been introduced in odlparent Aluminium and
suggests to explicit the serialVersionUID in serializable classes to
avoid compilers interoperability problems due to a Java implementation
design flaw.

If this is useful in a few situations (rare today), this also means that
theorically developers must maintain this field and increment it across
classes incompatible versions.
Practically, this step is often forgotten, paving the way to more
serious problems.
Since the situation here does not require it, it is healthier to simply
ignore this (soon obsolete?) recommendation.

For more details:
git log pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/PceLink.java
https://github.com/rzwitserloot/lombok/wiki/WHY-NOT:-serialVersionUID
https://moi.vonos.net/java/serialization-synthetic/
https://rules.sonarsource.com/java/RSPEC-4926
https://www.vojtechruzicka.com/explicitly-declare-serialversionuid/
https://www.infoworld.com/article/3275924/oracle-plans-to-dump-risky-java-serialization.html

JIRA: TRNSPRTPCE-292
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4e36134061104d912a75f3a578d43ca0bc17ab1f
(cherry picked from commit a00f3ee60b16735f27af765a5bf357c56a091bc5)
common/src/main/java/org/opendaylight/transportpce/common/mapping/SortPort121ByName.java
common/src/main/java/org/opendaylight/transportpce/common/mapping/SortPort221ByName.java
lighty/src/main/java/io/lighty/controllers/tpce/exception/TechnicalException.java
pce/src/main/java/org/opendaylight/transportpce/pce/SortPortsByName.java
pce/src/main/java/org/opendaylight/transportpce/pce/graph/PceGraphEdge.java
pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/PceLink.java