Fix & un-@Ignore AclServiceTest 66/45966/1
authorMichael Vorburger <vorburger@redhat.com>
Wed, 21 Sep 2016 10:05:17 +0000 (12:05 +0200)
committerMichael Vorburger <vorburger@redhat.com>
Wed, 21 Sep 2016 10:05:17 +0000 (12:05 +0200)
commitbbe3d000c414825f022337c175389b9c51ef475d
tree321590c93ba0bd3d0172c84c23bcb302e0b8d6e1
parentb897e8ef1358f859184675689fbf905d78a1d6cd
Fix & un-@Ignore AclServiceTest

It turns out that c/45261 re. "@Override init() instead @PostConstruct
start()" broke AclServiceTest (c/42109); somehow Mycila Guice
Jsr250Module interprets @PostConstruct in parent class, or protected VS
public, differently than Apache Aries Blueprint impl.

This fixes it by putting @PostConstruct back, for now.  I'll separately
investigate a cleaner fix (probably going either in Mycila Guice, Genius
or infrautils; not netvirt).

This problem was not seen pre-merge, and thus broke master, because we
are in the unhealthy habit of merging a bunch of changes without
re-re-rebasing EVERY change after EVERY merge.  While that certainly
adds some overhead for commiters and build infra, doing that would lead
to more stability in such cases, as well as avoid Guitar Hero git log
<https://twitter.com/henryhoffman/status/694184106440200192>, which in
turn would make it easier to locally try git revert and git bisect to
find out which commit cause what.

Change-Id: Ife74e3b920cca1fdf43fdf3aedc6401723050c46
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclEventListener.java
vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclInterfaceListener.java
vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclInterfaceStateListener.java
vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclNodeListener.java
vpnservice/aclservice/impl/src/test/java/org/opendaylight/netvirt/aclservice/tests/AclServiceTest.java