Bug 6585: BGP ChannelOutputLimiter waits forever 90/45390/2
authorMilos Fabian <milfabia@cisco.com>
Wed, 31 Aug 2016 15:40:49 +0000 (17:40 +0200)
committerMilos Fabian <milfabia@cisco.com>
Wed, 14 Sep 2016 09:32:18 +0000 (09:32 +0000)
commitcb5d141544093edf0acdbfdd73ca66758c66b819
treebd5346a450b7661652516ab7d4f8ca3099730678
parente65e1378acfdef6ab6f7e2fe115e7af716237281
Bug 6585: BGP ChannelOutputLimiter waits forever

After a while (when an output buffer reach upper bound),
BGP's ChannelOutputLimiter handler get stacked waiting for the channel to become writable again.
The writability change never happen, however socket flush is invoked,
so the session peer dies on holdtimer expiration.

Looks like calling #flush when writability changes to non-writable has no effect.
Invoking #flush in #ensureWritable makes the expected action.

Change-Id: I95681d87c30aff82ec360a2d13fc01fe35873507
Signed-off-by: Milos Fabian <milfabia@cisco.com>
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/ChannelOutputLimiter.java