Correct ClassTemplate's check for types 46/89146/6
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 20 Apr 2020 11:51:53 +0000 (13:51 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 20 Apr 2020 12:26:05 +0000 (14:26 +0200)
commitd6679921a4653547db4b7353871682f47dc953bf
treeca5e2a541f6c11c8f4f6b75df0a7cd8a2bc3e37d
parent85eff34b0e20b07042fcde68d9c5e32411194e07
Correct ClassTemplate's check for types

ClassTemplate's checks run against Java Types, which is fine, except
that we should be referencing them through BaseYangTypes, so that we
have the incidental alignment well covered.

Furthermore the checks rely on FQCN, which is potentially slow to
compute, while the new checks rely on plain type equality -- hence
potentially speeding up things and lowering the number of branches.

We also drop a FIXMEs to clarify situation around InstanceIdentifier.

Change-Id: I3328199a8ec56e28d58582c076f1344fb4459103
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/mdsal-binding-generator-util/src/main/java/org/opendaylight/mdsal/binding/model/util/BaseYangTypes.java
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/ClassTemplate.xtend