Fix findbugs violations in utils 37/69037/8
authorTom Pantelis <tompantelis@gmail.com>
Sat, 3 Mar 2018 17:04:27 +0000 (12:04 -0500)
committerTom Pantelis <tompantelis@gmail.com>
Mon, 12 Mar 2018 22:27:19 +0000 (18:27 -0400)
commite6b469e18d5f72402ccb817ce1fb1469dd2a9d6c
treee020d72297c77092c208b8010beb525f0a0d11ae
parent378aafd8e77feaaefb6b95866c53dd81f0afab67
Fix findbugs violations in utils

- Naked notify
- An apparent infinite recursive loop
- Field isn't final but should be
- Boxing/unboxing to parse a primitive
- Method concatenates strings using + in a loop
- Method ignores exceptional return value
- Reliance on default encoding
- Should be a static inner clas
- Could be refactored into a static inner class
- Result of integer multiplication cast to long

Change-Id: Ie10a638f81490f9ddc1c27f651c4471168c50bd6
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
utils/mdsal-utils/src/main/java/org/opendaylight/ovsdb/utils/mdsal/utils/NotifyingDataChangeListener.java
utils/ovsdb-it-utils/src/main/java/org/opendaylight/ovsdb/utils/ovsdb/it/utils/DockerOvs.java
utils/ovsdb-it-utils/src/main/java/org/opendaylight/ovsdb/utils/ovsdb/it/utils/ProcUtils.java
utils/southbound-utils/src/main/java/org/opendaylight/ovsdb/utils/southbound/utils/SouthboundUtils.java