Code Review / openflowplugin.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 04db20e) | patch
Eliminate AbstractEmptyActionDeserializer subclasses 88/92388/13
authorRobert Varga <robert.varga@pantheon.tech>
Wed, 2 Sep 2020 16:57:27 +0000 (18:57 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Fri, 18 Sep 2020 05:58:41 +0000 (07:58 +0200)
commite944df2de8ff33b322400b059570c9c846262855
treec0312f12df3722bcb11d7cae158c024b0a6aa4d4tree | snapshot
parent04db20e4b86f8ec29810e08c57b7434e4238a6a8commit | diff
Eliminate AbstractEmptyActionDeserializer subclasses

Method dispatch works on particular class implementation and
individual per-type subclasses are not bringing anything to the
table.

Change AbstractEmptyActionDeserializer to a final
EmptyActionDeserializer and use its instances to perform duties
previously held by its subclasses.

JIRA: OPNFLWPLUG-1102
Change-Id: I3e1e03a498a15808cf2538fcca651c6c258e07f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/ActionDeserializerInitializer.java diff | blob | history
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/action/EmptyActionDeserializer.java [moved from openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/action/AbstractEmptyActionDeserializer.java with 80% similarity] diff | blob | history
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/action/OF10StripVlanActionDeserializer.java [deleted file] blob | history
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/action/OF13CopyTtlInActionDeserializer.java [deleted file] blob | history
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/action/OF13CopyTtlOutActionDeserializer.java [deleted file] blob | history
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/action/OF13DecMplsTtlActionDeserializer.java [deleted file] blob | history
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/action/OF13DecNwTtlActionDeserializer.java [deleted file] blob | history
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/action/OF13PopPbbActionDeserializer.java [deleted file] blob | history
openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/action/OF13PopVlanActionDeserializer.java [deleted file] blob | history
OpenFlow Plugin