Fix findbugs violations in southbound-impl 26/69826/2
authorTom Pantelis <tompantelis@gmail.com>
Thu, 22 Mar 2018 16:24:47 +0000 (12:24 -0400)
committerTom Pantelis <tompantelis@gmail.com>
Fri, 23 Mar 2018 13:33:08 +0000 (09:33 -0400)
commitee3bd23b9533d762c4ae58530397acd1a461ed6a
tree276bbae1683b841e246f39f6f97aa4e722ac493c
parent443462fa015ee9edf758f0b69d5d4744289d53eb
Fix findbugs violations in southbound-impl

- Method invokes inefficient Number constructor; use static valueOf instead
- Inefficient use of keySet iterator instead of entrySet iterator
- Reliance on default encoding
- Method ignores exceptional return value
- Should be a static inner class
- Private method is never called
- Method invokes inefficient Number constructor; use static valueOf instead
- Return value of method without side effect is ignored
- Result of integer multiplication cast to long
- Dead store to local variable
- Write to static field from instance method
- Parameter must be non-null but is marked as nullable
- Redundant nullcheck of value known to be non-null

Change-Id: Ieba8b20d01a47d6b245bb2752f004aa18fd08469
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
18 files changed:
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionManager.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/SouthboundProvider.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/AutoAttachRemovedCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/AutoAttachUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/BridgeOperationalState.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/QosUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/QueueUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/TerminationPointUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/reconciliation/ReconciliationManager.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/reconciliation/connection/ConnectionReconciliationTask.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OpenVSwitchUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbAutoAttachUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbBridgeUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbPortRemoveCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbPortUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbQosUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbQueueUpdateCommand.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/TransactionInvokerImpl.java