Code Review / yangtools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: b002ad5) | patch
Bug 1123 - Fixed incorrect augment target resolving 87/7587/3
authorTony Tkacik <ttkacik@cisco.com>
Mon, 2 Jun 2014 14:10:24 +0000 (16:10 +0200)
committerTony Tkacik <ttkacik@cisco.com>
Tue, 3 Jun 2014 13:23:52 +0000 (15:23 +0200)
commitf0f4881e43b6765e5d5351ced0e7d44bc9d61d85
tree460e1754d3a53db4a45772ecf798d91949fb8ed5tree | snapshot
parentb002ad53d2910a5dd7f62dd48c8c14a4fc959fa2commit | diff
Bug 1123 - Fixed incorrect augment target resolving

- Introduced new ParserUtils#findSchemaNodeInModule
  in parser utils
  which uses SchemaPath, Iterable and full QName match
  to lookup builders for augmentations

- Updated augmentation resolution to use findSchemaNodeInModule
  to lookup correct augmentation target using
  full QName match (namespace, revision, localName) instead
  original algorithm using localName only.

- Updated incorrect negative tests for augmentations
  Added conflicting augmentations.

Change-Id: I36b814a85759605ef43eb65485d9ec592871fb15
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/impl/YangParserImpl.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/util/ParserUtils.java diff | blob | history
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/impl/YangParserNegativeTest.java diff | blob | history
yang/yang-parser-impl/src/test/resources/negative-scenario/duplicity/augment0.yang diff | blob | history
yang/yang-parser-impl/src/test/resources/negative-scenario/duplicity/augment1.yang diff | blob | history
yang/yang-parser-impl/src/test/resources/negative-scenario/duplicity/augment2.yang diff | blob | history
OpenDaylight YANG Tools