Code Review / netconf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 534f496) | patch
Fix unsafe global config access 87/82187/1
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 21 May 2019 11:27:02 +0000 (13:27 +0200)
committerRobert Varga <nite@hq.sk>
Tue, 21 May 2019 11:32:17 +0000 (11:32 +0000)
commitf157d2de42fc2c13c3bcda1608e810f26eb03680
tree7318f784ae2ef90e4ccead27b952b4be536d24dftree | snapshot
parent534f496b2de0267e2dc60ba1aa657c08142628eacommit | diff
Fix unsafe global config access

Current global config is a volatile variable, hence it must be
acquired into a local variable for proper nullness checks --
otherwise it is open to TOCTOU race conditions leading to NPEs.

Change-Id: I9316b3ed976575726da7a065668c507e15fe0ddf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
netconf/callhome-provider/src/main/java/org/opendaylight/netconf/callhome/mount/CallHomeAuthProviderImpl.java diff | blob | history
Netconf