git.opendaylight Code Review - bgpcep.git/commit

author	Robert Varga <robert.varga@pantheon.tech>
	Sat, 4 Jan 2020 22:22:28 +0000 (23:22 +0100)
committer	Robert Varga <robert.varga@pantheon.tech>
	Sun, 5 Jan 2020 00:18:45 +0000 (01:18 +0100)
commit	795c361af95e07b78ba8c4e0762f601ecec63499
tree	a3f53774c31eb27c535a32496b9dc9f7ab3a6609	tree \| snapshot
parent	2894d2f6aaf1ed73ff9253cbd2fe283a4a471aa0	commit \| diff

Remove useless UnsupportedOperationExceptions

It is a common (enforced) pattern to hide utility class constructors,
which is sufficient to make sure they are not instantiated.

Throwing UOE from them leads to unneeded byte code, which is hard to
test (via reflection). Remove all instances of such throws.

Change-Id: I68ff3596b44a2196d5450c220a30f98c014f7ba4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

112 files changed:

bgp/cli/src/main/java/org/opendaylight/protocol/bgp/cli/utils/BGPOperationalStateUtils.java		diff \| blob \| history
bgp/cli/src/main/java/org/opendaylight/protocol/bgp/cli/utils/GlobalStateCliUtils.java		diff \| blob \| history
bgp/cli/src/main/java/org/opendaylight/protocol/bgp/cli/utils/NeighborStateCliUtils.java		diff \| blob \| history
bgp/cli/src/main/java/org/opendaylight/protocol/bgp/cli/utils/PeerGroupStateCliUtils.java		diff \| blob \| history
bgp/concepts/src/main/java/org/opendaylight/bgp/concepts/IpAddressUtil.java		diff \| blob \| history
bgp/concepts/src/main/java/org/opendaylight/bgp/concepts/NextHopUtil.java		diff \| blob \| history
bgp/concepts/src/main/java/org/opendaylight/bgp/concepts/RouteDistinguisherUtil.java		diff \| blob \| history
bgp/extensions/evpn/src/main/java/org/opendaylight/protocol/bgp/evpn/impl/esi/types/ESIActivator.java		diff \| blob \| history
bgp/extensions/evpn/src/main/java/org/opendaylight/protocol/bgp/evpn/impl/esi/types/EsiModelUtil.java		diff \| blob \| history
bgp/extensions/evpn/src/main/java/org/opendaylight/protocol/bgp/evpn/impl/nlri/NlriActivator.java		diff \| blob \| history
bgp/extensions/evpn/src/main/java/org/opendaylight/protocol/bgp/evpn/impl/nlri/NlriModelUtil.java		diff \| blob \| history
bgp/extensions/evpn/src/test/java/org/opendaylight/protocol/bgp/evpn/impl/EvpnTestUtil.java		diff \| blob \| history
bgp/extensions/flowspec/src/main/java/org/opendaylight/protocol/bgp/flowspec/handlers/Util.java		diff \| blob \| history
bgp/extensions/l3vpn/src/main/java/org/opendaylight/protocol/bgp/l3vpn/mcast/nlri/L3vpnMcastNlriSerializer.java		diff \| blob \| history
bgp/extensions/l3vpn/src/main/java/org/opendaylight/protocol/bgp/l3vpn/unicast/VpnDestinationUtil.java		diff \| blob \| history
bgp/extensions/linkstate/src/main/java/org/opendaylight/protocol/bgp/linkstate/impl/attribute/TeLspAttributesParser.java		diff \| blob \| history
bgp/extensions/mvpn/src/main/java/org/opendaylight/protocol/bgp/mvpn/impl/NlriActivator.java		diff \| blob \| history
bgp/extensions/mvpn/src/main/java/org/opendaylight/protocol/bgp/mvpn/impl/TunnelIdentifierActivator.java		diff \| blob \| history
bgp/extensions/mvpn/src/main/java/org/opendaylight/protocol/bgp/mvpn/impl/attributes/OpaqueUtil.java		diff \| blob \| history
bgp/extensions/mvpn/src/main/java/org/opendaylight/protocol/bgp/mvpn/impl/attributes/tunnel/identifier/PAddressPMulticastGroupUtil.java		diff \| blob \| history
bgp/extensions/mvpn/src/main/java/org/opendaylight/protocol/bgp/mvpn/impl/nlri/CMulticastUtil.java		diff \| blob \| history
bgp/extensions/mvpn/src/main/java/org/opendaylight/protocol/bgp/mvpn/impl/nlri/Ipv4NlriHandler.java		diff \| blob \| history
bgp/extensions/mvpn/src/main/java/org/opendaylight/protocol/bgp/mvpn/impl/nlri/Ipv6NlriHandler.java		diff \| blob \| history
bgp/extensions/mvpn/src/main/java/org/opendaylight/protocol/bgp/mvpn/impl/nlri/MulticastGroupOpaqueUtil.java		diff \| blob \| history
bgp/extensions/mvpn/src/test/java/org/opendaylight/protocol/bgp/mvpn/impl/attributes/PMSITunnelAttributeHandlerTestUtil.java		diff \| blob \| history
bgp/extensions/route-target/src/main/java/org/opendaylight/protocol/bgp/route/targetcontrain/impl/activators/NlriActivator.java		diff \| blob \| history
bgp/extensions/route-target/src/main/java/org/opendaylight/protocol/bgp/route/targetcontrain/spi/RouteTargetMembeshipUtil.java		diff \| blob \| history
bgp/openconfig-api/src/main/java/org/opendaylight/yang/gen/v1/http/openconfig/net/yang/local/routing/rev151009/LocalStaticConfigNextHopBuilder.java		diff \| blob \| history
bgp/openconfig-api/src/main/java/org/opendaylight/yang/gen/v1/http/openconfig/net/yang/network/instance/types/rev151018/RouteDistinguisherBuilder.java		diff \| blob \| history
bgp/openconfig-rp-spi/src/main/java/org/opendaylight/protocol/bgp/openconfig/routing/policy/spi/registry/BgpAttributeConditionsUtil.java		diff \| blob \| history
bgp/openconfig-rp-statement/src/test/java/org/opendaylight/protocol/bgp/openconfig/routing/policy/statement/ExportAttributeTestUtil.java		diff \| blob \| history
bgp/openconfig-rp-statement/src/test/java/org/opendaylight/protocol/bgp/openconfig/routing/policy/statement/ImportAttributeTestUtil.java		diff \| blob \| history
bgp/openconfig-state/src/main/java/org/opendaylight/protocol/bgp/state/GlobalUtil.java		diff \| blob \| history
bgp/openconfig-state/src/main/java/org/opendaylight/protocol/bgp/state/NeighborUtil.java		diff \| blob \| history
bgp/openconfig-state/src/main/java/org/opendaylight/protocol/bgp/state/PeerGroupUtil.java		diff \| blob \| history
bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/AsNumberUtil.java		diff \| blob \| history
bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BgpExtendedMessageUtil.java		diff \| blob \| history
bgp/parser-impl/src/main/java/org/opendaylight/protocol/bgp/parser/impl/message/update/extended/communities/route/target/As4RouteTargetExtendedHandler.java		diff \| blob \| history
bgp/parser-impl/src/main/java/org/opendaylight/protocol/bgp/parser/impl/message/update/extended/communities/route/target/RouteTargetExtendedCommunityHandler.java		diff \| blob \| history
bgp/parser-impl/src/main/java/org/opendaylight/protocol/bgp/parser/impl/message/update/extended/communities/route/target/RouteTargetIpv4Handler.java		diff \| blob \| history
bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BgpPrefixSidTlvUtil.java		diff \| blob \| history
bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MultiPathSupportUtil.java		diff \| blob \| history
bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MultiprotocolCapabilitiesUtil.java		diff \| blob \| history
bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/PathIdUtil.java		diff \| blob \| history
bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/extended/community/FourOctAsCommonECUtil.java		diff \| blob \| history
bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/extended/community/Inet4SpecificExtendedCommunityCommonUtil.java		diff \| blob \| history
bgp/path-selection-mode/src/main/java/org/opendaylight/protocol/bgp/mode/BesthPathStateUtil.java		diff \| blob \| history
bgp/path-selection-mode/src/main/java/org/opendaylight/protocol/bgp/mode/impl/base/BasePathSelectionModeFactory.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BgpPeerUtil.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/CountersUtil.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/config/OpenConfigMappingUtil.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/config/RoutingPolicyUtil.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/CheckUtil.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/PeerUtil.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/config/RIBTestsUtil.java		diff \| blob \| history
bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/IdentifierUtils.java		diff \| blob \| history
bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/PeerRoleUtil.java		diff \| blob \| history
bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java		diff \| blob \| history
bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RouterIds.java		diff \| blob \| history
bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/util/ClusterSingletonServiceRegistrationHelper.java		diff \| blob \| history
bgp/testtool/src/main/java/org/opendaylight/protocol/bgp/testtool/BGPPeerBuilder.java		diff \| blob \| history
bgp/testtool/src/main/java/org/opendaylight/protocol/bgp/testtool/CommunitiesBuilder.java		diff \| blob \| history
bgp/testtool/src/main/java/org/opendaylight/protocol/bgp/testtool/Main.java		diff \| blob \| history
bgp/testtool/src/main/java/org/opendaylight/protocol/bgp/testtool/PrefixesBuilder.java		diff \| blob \| history
bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/ProtocolUtil.java		diff \| blob \| history
bgp/util/src/main/java/org/opendaylight/protocol/bgp/util/BinaryBGPDumpFileParser.java		diff \| blob \| history
bgp/util/src/main/java/org/opendaylight/protocol/bgp/util/HexDumpBGPFileParser.java		diff \| blob \| history
bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/BmpDispatcherUtil.java		diff \| blob \| history
bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/KeyConstructorUtil.java		diff \| blob \| history
bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java		diff \| blob \| history
bmp/bmp-mock/src/main/java/org/opendaylight/protocol/bmp/mock/BmpMock.java		diff \| blob \| history
bmp/bmp-mock/src/main/java/org/opendaylight/protocol/bmp/mock/BmpMockUtil.java		diff \| blob \| history
bmp/bmp-parser-impl/src/test/java/org/opendaylight/protocol/bmp/parser/message/TestUtil.java		diff \| blob \| history
bmp/bmp-spi/src/main/java/org/opendaylight/protocol/bmp/spi/parser/BmpMessageConstants.java		diff \| blob \| history
bmp/bmp-spi/src/main/java/org/opendaylight/protocol/bmp/spi/parser/TlvUtil.java		diff \| blob \| history
pcep/base-parser/src/main/java/org/opendaylight/protocol/pcep/parser/object/bnc/BNCUtil.java		diff \| blob \| history
pcep/base-parser/src/main/java/org/opendaylight/protocol/pcep/parser/subobject/AsNumberCaseParser.java		diff \| blob \| history
pcep/base-parser/src/main/java/org/opendaylight/protocol/pcep/parser/util/Util.java		diff \| blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/spi/Util.java		diff \| blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/tls/SslKeyStore.java		diff \| blob \| history
pcep/impl/src/test/java/org/opendaylight/protocol/pcep/impl/UtilTest.java		diff \| blob \| history
pcep/pcc-mock/src/main/java/org/opendaylight/protocol/pcep/pcc/mock/Main.java		diff \| blob \| history
pcep/pcc-mock/src/main/java/org/opendaylight/protocol/pcep/pcc/mock/PCCTunnelBuilder.java		diff \| blob \| history
pcep/pcc-mock/src/main/java/org/opendaylight/protocol/pcep/pcc/mock/spi/MsgBuilderUtil.java		diff \| blob \| history
pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/pojo/ServiceLoaderPCEPExtensionProviderContext.java		diff \| blob \| history
pcep/testtool/src/test/java/org/opendaylight/protocol/pcep/testtool/PCCMock.java		diff \| blob \| history
pcep/topology/cli/src/main/java/org/opendaylight/protocol/pcep/cli/utils/PcepStateUtils.java		diff \| blob \| history
pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/config/PCEPTopologyProviderUtil.java		diff \| blob \| history
pcep/tunnel/tunnel-provider/src/main/java/org/opendaylight/bgpcep/pcep/tunnel/provider/TunelProgrammingUtil.java		diff \| blob \| history
programming/api/src/main/java/org/opendaylight/bgpcep/programming/NanotimeUtil.java		diff \| blob \| history
programming/topology-api/src/main/java/org/opendaylight/bgpcep/programming/topology/TopologyProgrammingUtil.java		diff \| blob \| history
programming/tunnel-api/src/main/java/org/opendaylight/bgpcep/programming/tunnel/TunnelProgrammingUtil.java		diff \| blob \| history
rsvp/api/src/main/java/org/opendaylight/yang/gen/v1/urn/opendaylight/params/xml/ns/yang/rsvp/rev150820/PceIdBuilder.java		diff \| blob \| history
rsvp/impl/src/main/java/org/opendaylight/protocol/rsvp/parser/impl/subobject/AsNumberCaseParser.java		diff \| blob \| history
rsvp/impl/src/main/java/org/opendaylight/protocol/rsvp/parser/impl/subobject/label/LabelUtil.java		diff \| blob \| history
rsvp/impl/src/main/java/org/opendaylight/protocol/rsvp/parser/impl/subobject/rro/RROSubobjectUtil.java		diff \| blob \| history
rsvp/impl/src/main/java/org/opendaylight/protocol/rsvp/parser/impl/subobject/xro/XROSubobjectUtil.java		diff \| blob \| history
rsvp/spi/src/main/java/org/opendaylight/protocol/rsvp/parser/spi/EROSubobjectUtil.java		diff \| blob \| history
rsvp/spi/src/main/java/org/opendaylight/protocol/rsvp/parser/spi/pojo/ServiceLoaderRSVPExtensionProviderContext.java		diff \| blob \| history
rsvp/spi/src/test/java/org/opendaylight/protocol/rsvp/parser/spi/pojo/ServiceLoaderRSVPExtensionProviderContextTest.java		diff \| blob \| history
testtool-util/src/main/java/org/opendaylight/protocol/util/CheckTestUtil.java		diff \| blob \| history
testtool-util/src/main/java/org/opendaylight/protocol/util/CheckUtil.java		diff \| blob \| history
testtool-util/src/main/java/org/opendaylight/protocol/util/InetSocketAddressUtil.java		diff \| blob \| history
testtool-util/src/main/java/org/opendaylight/protocol/util/LoggerUtil.java		diff \| blob \| history
util/src/main/java/org/opendaylight/protocol/util/ByteArray.java		diff \| blob \| history
util/src/main/java/org/opendaylight/protocol/util/ByteBufWriteUtil.java		diff \| blob \| history
util/src/main/java/org/opendaylight/protocol/util/Ipv4Util.java		diff \| blob \| history
util/src/main/java/org/opendaylight/protocol/util/Ipv6Util.java		diff \| blob \| history
util/src/main/java/org/opendaylight/protocol/util/MplsLabelUtil.java		diff \| blob \| history
util/src/main/java/org/opendaylight/protocol/util/PCEPHexDumpParser.java		diff \| blob \| history
util/src/main/java/org/opendaylight/protocol/util/StatisticsUtil.java		diff \| blob \| history
util/src/main/java/org/opendaylight/protocol/util/Values.java		diff \| blob \| history

BGP/PCEP protocol library

RSS Atom