git.opendaylight Code Review - netconf.git/commit

author	Robert Varga <robert.varga@pantheon.tech>
	Fri, 13 Oct 2023 21:12:03 +0000 (23:12 +0200)
committer	Robert Varga <robert.varga@pantheon.tech>
	Sat, 14 Oct 2023 00:11:20 +0000 (02:11 +0200)
commit	55ae31a6b28e51a2a120fc7fbd50a7f31f9e4bdb
tree	aa8203b2987092b968af8b7a7d0de52d11356835	tree \| snapshot
parent	d901d1c6fb1adb2aa88639437c49d26efd3bba5e	commit \| diff

Clean up SSH server subsystem handling

SSH transport should not report a connection until it has established
the expected transport channel.

This patch reworks the API to instantiation and internal wiring, so that
we invoke TransportChannelListener only once the subsystem has been
allocated.

This has the nice side-effect of reducing shaded.ssh package
proliferation, as things just end up being better encapsualted.

JIRA: NETCONF-1106
Change-Id: Ifcfc3a99d1fa323b105c87724c34f9bba018b78a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

23 files changed:

apps/netconf-nb/src/main/java/org/opendaylight/netconf/northbound/SshServerTransport.java		diff \| blob \| history
apps/netconf-nb/src/main/java/org/opendaylight/netconf/northbound/TcpServerTransport.java		diff \| blob \| history
netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/AbstractNetconfSession.java		diff \| blob \| history
protocol/netconf-server/pom.xml		diff \| blob \| history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/BaseServerTransport.java	[deleted file]	blob \| history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerFactoryImpl.java		diff \| blob \| history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfSubsystem.java	[deleted file]	blob \| history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfSubsystemFactory.java	[deleted file]	blob \| history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/ServerTransportInitializer.java	[moved from protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/BaseTransportChannelListener.java with 50% similarity]	diff \| blob \| history
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/OutboundChannelHandler.java		diff \| blob \| history
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/SSHClient.java		diff \| blob \| history
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/SSHServer.java		diff \| blob \| history
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/SSHTransportStack.java		diff \| blob \| history
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/SSHTransportStackFactory.java		diff \| blob \| history
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/TransportChannelSession.java	[new file with mode: 0644]	blob
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/TransportChannelSessionFactory.java	[new file with mode: 0644]	blob
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/TransportClientSubsystem.java		diff \| blob \| history
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/TransportServerSession.java	[new file with mode: 0644]	blob
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/TransportServerSessionFactory.java	[new file with mode: 0644]	blob
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/TransportServerSubsystem.java	[new file with mode: 0644]	blob
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/TransportSshServer.java		diff \| blob \| history
transport/transport-ssh/src/main/java/org/opendaylight/netconf/transport/ssh/TransportUtils.java		diff \| blob \| history
transport/transport-ssh/src/test/java/org/opendaylight/netconf/transport/ssh/SshClientServerTest.java		diff \| blob \| history

Netconf

RSS Atom