Code Review / transportpce.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 62e0652) | patch
Enforce SpotBugs in Service handler 17/91117/1
authorguillaume.lambert <guillaume.lambert@orange.com>
Wed, 6 May 2020 10:41:13 +0000 (12:41 +0200)
committerGilles Thouenon <gilles.thouenon@orange.com>
Fri, 10 Jul 2020 12:46:53 +0000 (14:46 +0200)
commit6b8f9f2da77e118e3020afd465844147f807a177
treebeb30d871ffd959fc0250249f5b071fc7f82db13tree | snapshot
parent62e0652c1ad39b9763ff2967d72f90e2e08dbdd3commit | diff
Enforce SpotBugs in Service handler

and fix ServiceHandler SLF4J SpotBugs issues.
By the way:
- rename ServiceHandlerCompliancyCheck class for coherence
- clean ModelMappingUtils.java and ServicehandlerImpl.java
- review how messages and logs are handled
- improve Junit tests

JIRA: TRNSPRTPCE-214 TRNSPRTPCE-246 TRNSPRTPCE-265
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I82e1ac784bb66acbdcf62004da6da6eb3701434b
13 files changed:
servicehandler/pom.xml diff | blob | history
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/ModelMappingUtils.java diff | blob | history
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/impl/ServicehandlerImpl.java diff | blob | history
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/service/ServiceDataStoreOperationsImpl.java diff | blob | history
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/ServiceCreateValidation.java diff | blob | history
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ComplianceCheckResult.java diff | blob | history
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerComplianceCheck.java [new file with mode: 0644] blob
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerCompliancyCheck.java [deleted file] blob | history
servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerTxRxCheck.java diff | blob | history
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/impl/ServicehandlerImplTest.java diff | blob | history
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/service/ServiceDataStoreOperationsImplTest.java diff | blob | history
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerComplianceCheckTest.java [moved from servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerCompliancyCheckTest.java with 64% similarity] diff | blob | history
servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/validation/checks/ServicehandlerTxRxCheckTest.java diff | blob | history
Repository for Transport PCE project.