Clean up SfcOpenflowUtilsTest and re-enable all tests 30/31530/2
authorStephen Kitt <[email protected]>
Thu, 17 Dec 2015 17:41:31 +0000 (18:41 +0100)
committerBrady Johnson <[email protected]>
Fri, 18 Dec 2015 16:24:51 +0000 (16:24 +0000)
commitf970eb0f804af0233f273d74d842c9f4b3d37b4b
tree41ac3d0daa0c9094ee2f430b1a29581c2afa0deb
parent4a81452bcef59362df048aa2639c1aeef60de142
Clean up SfcOpenflowUtilsTest and re-enable all tests

nextHopGroupIdArray isn't used, remove it.
(int) random() is always 0 (because of rounding), use the default
Random() constructor.
Drop redundant casts.
static methods are final, drop the redundant final modifier.
All the parameter creation methods are used but untrackable, suppress
the unused warnings.
Remove commented code.
Fix shouldThrowExceptionForCreateSetAction() and re-enable it.

Change-Id: I6b14f161eb3c96d5170030b34bc0c6cd0776cae1
Signed-off-by: Stephen Kitt <[email protected]>
sfc-util/sfc-openflow-utils/src/test/java/org/opendaylight/sfc/util/openflow/SfcOpenflowUtilsTest.java