Revert "Checkstyle TrailingComment, Sonar aligned" 36/65136/2
authorMichael Vorburger <vorburger@redhat.com>
Sat, 4 Nov 2017 03:15:10 +0000 (04:15 +0100)
committerRobert Varga <nite@hq.sk>
Tue, 7 Nov 2017 16:07:20 +0000 (16:07 +0000)
commit8c22caa5e4562ef2e92bd35098ff7f9bfae2d52b
tree018c0971397883717e4a9db11507c6cfc1875152
parentb61f5c45bc90132129f50f3af166f3af4d322bac
Revert "Checkstyle TrailingComment, Sonar aligned"

This reverts commit f7680f6a688e26e28515c907328c52d0a35a4515.

This code format convention is actually stupid IMHO after all.
For example, I really do like this a lot more:

  @SuppressFBWarnings("SE_BAD_FIELD") // Runnable is not Serializable
  private final TrackingLinkedBlockingQueue<Runnable> backingQueue;

than being forced by Checkstyle to have to write this:

  // Runnable is not Serializable
  @SuppressFBWarnings("SE_BAD_FIELD")
  private final TrackingLinkedBlockingQueue<Runnable> backingQueue;

We should change Sonar's configuraiton, not enforce this in odlparent.

Change-Id: Ib3a8708a7a4b43bb72859f69aca33aafb8b6080c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
checkstyle/src/main/resources/odl_checks.xml
features-test/src/main/java/org/opendaylight/odlparent/featuretest/ReflectionUtil.java
features-test/src/main/java/org/opendaylight/odlparent/featuretest/SingleFeatureTest.java