De-confuse InvocationHandler and target methods 80/86080/8
authorRobert Varga <robert.varga@pantheon.tech>
Sun, 1 Dec 2019 10:04:32 +0000 (11:04 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 2 Dec 2019 11:20:08 +0000 (12:20 +0100)
commit2cf87f876c50a276f6e5ddafc2fb44d5b6c26fbd
treec69d39c0225b8c40b9ee020765396b848c30d52c
parent66489f05a0ea64c09f5f33d64e5ec5a8ebbd1f69
De-confuse InvocationHandler and target methods

Having hashCode()/equals()/toString() implemented in InvocationHandler
could lead to confusing the handler with the object being proxied. It
furthermore violates equality contract requirement of being reflexive
-- the handler ends up being equal to other implementations of proxied
interface, but any other implementation would either have to handle
it specifically, or will determined it being non-equal.

Clean up the confusion by renaming the methods and have default
implementations take over. This is explicitly fine, as we do not have
any code accessing the handler directly, only through the proxy.
This also eliminates the need to suppress warnings.

Change-Id: Iac42d09b5a44716e8293c6b1e9003a780efae6f8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
library/impl/src/main/java/org/opendaylight/ovsdb/lib/schema/typed/TyperUtils.java