Code Review / netconf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 23887ff) | patch
Release the buffer only after we are done with it 84/77084/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 18 Oct 2018 15:25:55 +0000 (17:25 +0200)
committerRobert Varga <nite@hq.sk>
Thu, 18 Oct 2018 15:29:29 +0000 (15:29 +0000)
commit92708e68b817912bd6fd6814805017cc24a9875f
treedbb0b75517fcdaf6ba4ebe929cfc3939611314d2tree | snapshot
parent23887ff5bac8a64eaf362ba01fc2afe730257c69commit | diff
Release the buffer only after we are done with it

We may end up touching the buffer after we have release()'d it,
which means it may have been recycled by the time we call
resetReaderIndex().

Move the release() call to after the check so we do not end up
releasing it prematurely.

Change-Id: I43156dbe2e6c53a552a322e7b5ea27f8da3873c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/handler/ssh/client/AsyncSshHandlerWriter.java diff | blob | history
Netconf