git.opendaylight Code Review - openflowplugin.git/commit

Code Review / openflowplugin.git / commit

author	Sangwook Ha <sangwook.ha@verizon.com>
	Wed, 17 Nov 2021 06:53:08 +0000 (22:53 -0800)
committer	Sangwook Ha <sangwook.ha@verizon.com>
	Thu, 18 Nov 2021 06:53:46 +0000 (06:53 +0000)
commit	43ec4df07fb4bc2a937bcb32d7a1d0e394bd6410
tree	50d47ab75738d35ca44998fa60b656c73484274e	tree \| snapshot
parent	b4b1b9201eae7f17f081172a875914c4e8dfbdc3	commit \| diff

Refactor FRM unit tests

Move common setup procedure to the parent class FRMTest to reduce
code duplication, and replace RpcProviderRegistryMock with
simple mocking.

Return a future, instead of null, to avoid null pointer exception
during the test, and remove the wrapper assertCommit.

Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
Change-Id: Ic4f3f92d17c79c73bc6928820e206d07e6ec058b

13 files changed:

applications/forwardingrules-manager/src/test/java/test/mock/FlowListenerTest.java		diff \| blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/GroupListenerTest.java		diff \| blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/MeterListenerTest.java		diff \| blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/NodeListenerTest.java		diff \| blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/TableFeaturesListenerTest.java		diff \| blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/util/AbstractFRMTest.java	[new file with mode: 0644]	blob
applications/forwardingrules-manager/src/test/java/test/mock/util/FRMTest.java	[deleted file]	blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/util/RpcProviderRegistryMock.java	[deleted file]	blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/util/SalBundleServiceMock.java		diff \| blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/util/SalFlowServiceMock.java		diff \| blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/util/SalGroupServiceMock.java		diff \| blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/util/SalMeterServiceMock.java		diff \| blob \| history
applications/forwardingrules-manager/src/test/java/test/mock/util/SalTableServiceMock.java		diff \| blob \| history

OpenFlow Plugin

RSS Atom