Code Review / mdsal.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 29da4cd) | patch
Clean up AbstractRegistrationTree 33/109233/3
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 8 Dec 2023 19:22:56 +0000 (20:22 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Fri, 8 Dec 2023 19:59:30 +0000 (20:59 +0100)
commitb6f64a5f14d581ce924f8b2eb54678f788f415ba
tree493355c5f1f438f87fb82ebb179f013990dab8d8tree | snapshot
parent29da4cd60675b60a601c8564b45861801196c75bcommit | diff
Clean up AbstractRegistrationTree

Inline RegistrationTree{Node,Snapshot} and perform general cleanups:
- hide snapshot() method so it can only be invoked from subclasses
- add @VisibleForTesting annotations
- use Map.computeIfAbsent()
- use local variable type inference
- check result of Collection.remove() on cleanup

JIRA: MDSAL-843
Change-Id: I4776be432da92bfe2f81d0551dd0d81184380987
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/AbstractRegistrationTree.java diff | blob | history
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/RegistrationTreeNode.java [deleted file] blob | history
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/RegistrationTreeSnapshot.java [deleted file] blob | history
dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/store/AbstractDOMStoreTreeChangePublisher.java diff | blob | history
dom/mdsal-dom-spi/src/test/java/org/opendaylight/mdsal/dom/spi/AbstractRegistrationTreeTest.java diff | blob | history
dom/mdsal-dom-spi/src/test/java/org/opendaylight/mdsal/dom/spi/RegistrationTreeNodeTest.java diff | blob | history
dom/mdsal-dom-spi/src/test/java/org/opendaylight/mdsal/dom/spi/RegistrationTreeSnapshotTest.java diff | blob | history
MD-SAL: Model-Driven Service Adaptation Layer