Code Review / openflowplugin.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: ce80c72) | patch
Drop locking from FlowGroupInfoHistoryImpl 02/94602/2
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 11 Jan 2021 19:17:31 +0000 (20:17 +0100)
committerRobert Varga <nite@hq.sk>
Mon, 11 Jan 2021 20:18:04 +0000 (20:18 +0000)
commitf3b790bf35d23d539fc47eb9c28db9da4304259a
treeb84e06539efcb0ad56d0a3b70778158ed79aab10tree | snapshot
parentce80c72b4bf4e0d82db60bbbee9ce9c844e338b0commit | diff
Drop locking from FlowGroupInfoHistoryImpl

Updates here are in the fast path and we are taking locks for
something that is used ... almost never.

Remove locking and perform time-bound retries to acquire entries
instead, explaining the situation in comments.

If this is not sufficient, a TODO is also added as to what needs
to happen to make the entry acquisition reliable.

Change-Id: I21d05e074bb5033942ef4f7d0bc210a2e9bbf359
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/history/FlowGroupInfoHistoryImpl.java diff | blob | history
OpenFlow Plugin