import io.netty.channel.ChannelHandlerContext;
import io.netty.handler.codec.MessageToByteEncoder;
import io.netty.util.concurrent.Future;
-
import org.opendaylight.openflowjava.protocol.impl.core.connection.MessageListenerWrapper;
import org.opendaylight.openflowjava.protocol.impl.serialization.SerializationFactory;
import org.opendaylight.openflowjava.statistics.CounterEventTypes;
*/
public class OFEncoder extends MessageToByteEncoder<MessageListenerWrapper> {
- private static final Logger LOGGER = LoggerFactory.getLogger(OFEncoder.class);
+ private static final Logger LOG = LoggerFactory.getLogger(OFEncoder.class);
private SerializationFactory serializationFactory;
- private StatisticsCounters statisticsCounters;
+ private final StatisticsCounters statisticsCounters;
/** Constructor of class */
public OFEncoder() {
statisticsCounters = StatisticsCounters.getInstance();
- LOGGER.trace("Creating OF13Encoder");
+ LOG.trace("Creating OF13Encoder");
}
@Override
- protected void encode(ChannelHandlerContext ctx, MessageListenerWrapper wrapper, ByteBuf out)
+ protected void encode(final ChannelHandlerContext ctx, final MessageListenerWrapper wrapper, final ByteBuf out)
throws Exception {
- LOGGER.trace("Encoding");
+ LOG.trace("Encoding");
try {
serializationFactory.messageToBuffer(wrapper.getMsg().getVersion(), out, wrapper.getMsg());
if(wrapper.getMsg() instanceof FlowModInput){
statisticsCounters.incrementCounter(CounterEventTypes.DS_FLOW_MODS_SENT);
}
statisticsCounters.incrementCounter(CounterEventTypes.DS_ENCODE_SUCCESS);
- } catch(Exception e) {
- LOGGER.warn("Message serialization failed ", e);
+ } catch(final Exception e) {
+ LOG.warn("Message serialization failed ", e);
statisticsCounters.incrementCounter(CounterEventTypes.DS_ENCODE_FAIL);
- Future<Void> newFailedFuture = ctx.newFailedFuture(e);
- wrapper.getListener().operationComplete(newFailedFuture);
+ if (wrapper.getListener() != null) {
+ final Future<Void> newFailedFuture = ctx.newFailedFuture(e);
+ wrapper.getListener().operationComplete(newFailedFuture);
+ }
out.clear();
return;
}
/**
* @param serializationFactory
*/
- public void setSerializationFactory(SerializationFactory serializationFactory) {
+ public void setSerializationFactory(final SerializationFactory serializationFactory) {
this.serializationFactory = serializationFactory;
}
package org.opendaylight.openflowjava.protocol.impl.core.connection;
import com.google.common.base.Preconditions;
-import io.netty.channel.ChannelFuture;
import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.ChannelInboundHandlerAdapter;
import io.netty.util.concurrent.Future;
import java.net.InetSocketAddress;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
+import javax.annotation.Nonnull;
import org.opendaylight.openflowjava.protocol.api.connection.OutboundQueueHandler;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.BarrierInput;
import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.EchoReplyInput;
conditionalFlush();
}
+ @Override
public void handlerAdded(final ChannelHandlerContext ctx) throws Exception {
/*
* Tune channel write buffering. We increase the writability window
void onEchoRequest(final EchoRequestMessage message) {
final EchoReplyInput reply = new EchoReplyInputBuilder().setData(message.getData())
.setVersion(message.getVersion()).setXid(message.getXid()).build();
- final SimpleRpcListener simpleMsgRpcListener = new SimpleRpcListener(reply, "echo-reply sending failed");
-
- final GenericFutureListener<Future<Void>> msgProcessListener = simpleMsgRpcListener.takeListener();
- final Object messageListenerWrapper;
- if (address == null) {
- messageListenerWrapper = new MessageListenerWrapper(simpleMsgRpcListener.takeMessage(), msgProcessListener);
- } else {
- messageListenerWrapper = new UdpMessageListenerWrapper(simpleMsgRpcListener.takeMessage(), msgProcessListener, address);
- }
- final ChannelFuture channelFuture = parent.getChannel().writeAndFlush(messageListenerWrapper);
- if (msgProcessListener != null) {
- channelFuture.addListener(msgProcessListener);
- }
+ parent.getChannel().writeAndFlush(makeMessageListenerWrapper(reply));
}
/**
* adding overhead.
*/
void writeMessage(final OfHeader message, final long now) {
- final Object wrapper;
- if (address == null) {
- wrapper = new MessageListenerWrapper(message, null);
- } else {
- wrapper = new UdpMessageListenerWrapper(message, null, address);
- }
+ final Object wrapper = makeMessageListenerWrapper(message);
parent.getChannel().write(wrapper);
if (message instanceof BarrierInput) {
}
}
}
+
+ /**
+ * Wraps outgoing message and includes listener attached to this message
+ * which is send to OFEncoder for serialization. Correct wrapper is
+ * selected by communication pipeline.
+ *
+ * @return
+ */
+ private Object makeMessageListenerWrapper(@Nonnull final OfHeader msg) {
+ Preconditions.checkArgument(msg != null);
+
+ if (address == null) {
+ return new MessageListenerWrapper(msg, LOG_ENCODER_LISTENER);
+ }
+ return new UdpMessageListenerWrapper(msg, LOG_ENCODER_LISTENER, address);
+ }
+
+ /* NPE are coming from {@link OFEncoder#encode} from catch block and we don't wish to lost it */
+ private static final GenericFutureListener<Future<Void>> LOG_ENCODER_LISTENER = new GenericFutureListener<Future<Void>>() {
+
+ private final Logger LOGGER = LoggerFactory.getLogger("LogEncoderListener");
+
+ @Override
+ public void operationComplete(final Future<Void> future) throws Exception {
+ if (future.cause() != null) {
+ LOGGER.warn("Message encoding fail !", future.cause());
+ }
+ }
+ };
}