Fix the FinalClass checkstyle violation described in this pending
change:
https://git.opendaylight.org/gerrit/#/c/43324/
Move the constructor to be the first method.
The same fix solved in this patch:
https://git.opendaylight.org/gerrit/#/c/53250/
Change-Id: I1986199ee2b761e1b73cac31f2f1630f57e73b64
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
- * Copyright (c) 2016 Red Hat, Inc. and others. All rights reserved.
+ * Copyright (c) 2016, 2017 Red Hat, Inc. and others. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
*
* @author Michael Vorburger.ch
*/
*
* @author Michael Vorburger.ch
*/
-public class BundleDiagInfos {
+public final class BundleDiagInfos {
private final List<String> okBundleStateInfoTexts;
private final List<String> nokBundleStateInfoTexts;
private final List<String> okBundleStateInfoTexts;
private final List<String> nokBundleStateInfoTexts;
private static final Map<String, BundleState> WHITELISTED_BUNDLES = ImmutableMap.of(
"slf4j.log4j12", Installed);
private static final Map<String, BundleState> WHITELISTED_BUNDLES = ImmutableMap.of(
"slf4j.log4j12", Installed);
+ private BundleDiagInfos(List<String> okBundleStateInfoTexts, List<String> nokBundleStateInfoTexts,
+ List<String> whitelistedBundleStateInfoTexts, Map<BundleState, Integer> bundleStatesCounters) {
+ this.okBundleStateInfoTexts = ImmutableList.copyOf(okBundleStateInfoTexts);
+ this.nokBundleStateInfoTexts = ImmutableList.copyOf(nokBundleStateInfoTexts);
+ this.whitelistedBundleStateInfoTexts = ImmutableList.copyOf(whitelistedBundleStateInfoTexts);
+ this.bundleStatesCounters = ImmutableMap.copyOf(bundleStatesCounters);
+ }
+
public static BundleDiagInfos forContext(BundleContext bundleContext, BundleService bundleService) {
List<String> okBundleStateInfoTexts = new ArrayList<>();
List<String> nokBundleStateInfoTexts = new ArrayList<>();
public static BundleDiagInfos forContext(BundleContext bundleContext, BundleService bundleService) {
List<String> okBundleStateInfoTexts = new ArrayList<>();
List<String> nokBundleStateInfoTexts = new ArrayList<>();
- private BundleDiagInfos(List<String> okBundleStateInfoTexts, List<String> nokBundleStateInfoTexts,
- List<String> whitelistedBundleStateInfoTexts, Map<BundleState, Integer> bundleStatesCounters) {
- this.okBundleStateInfoTexts = ImmutableList.copyOf(okBundleStateInfoTexts);
- this.nokBundleStateInfoTexts = ImmutableList.copyOf(nokBundleStateInfoTexts);
- this.whitelistedBundleStateInfoTexts = ImmutableList.copyOf(whitelistedBundleStateInfoTexts);
- this.bundleStatesCounters = ImmutableMap.copyOf(bundleStatesCounters);
- }
-
public SystemState getSystemState() {
if (bundleStatesCounters.get(BundleState.Failure) > 0) {
return SystemState.Failure;
public SystemState getSystemState() {
if (bundleStatesCounters.get(BundleState.Failure) > 0) {
return SystemState.Failure;