ShellCheck is useful for finding common bad patterns in shell script
code. We're trying to enable ShellCheck for the entire releng/builder
repo. Refer to Trello for further details.
Trello: https://trello.com/c/MlgqXKq6
Change-Id: Ife828f7b9a4c12042bef0a2fe626928faf6de6e2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
fi
echo "Scanning $directory"
fi
echo "Scanning $directory"
-for x in $(find $directory -type f); do
+while IFS= read -r -d '' x
+do
if LC_ALL=C grep -q '[^[:print:][:space:]]' "$x"; then
if LC_ALL=C grep -q '[^[:print:][:space:]]' "$x"; then
- echo "file "$x" contains non-ascii characters"
+ echo "file $x contains non-ascii characters"
+done < <(find "$directory" -type f -print0)
echo "All files are ASCII only"
echo "All files are ASCII only"
search_string=$1
echo -n "Enter system (sandbox|releng): "
search_string=$1
echo -n "Enter system (sandbox|releng): "
echo -n "Enter username: "
echo -n "Enter username: "
echo -n "Enter api_token: "
echo -n "Enter api_token: "
-echo $username:$password
+echo "$username:$password"
-wget -O jenkins-jobs.xml https://jenkins.opendaylight.org/$system/api/xml
+wget -O jenkins-jobs.xml "https://jenkins.opendaylight.org/$system/api/xml"
-jobs=`xmlstarlet sel -t -m '//hudson/job' \
+jobs=$(xmlstarlet sel -t -m '//hudson/job' \
-n -v 'name' jenkins-jobs.xml | \
-n -v 'name' jenkins-jobs.xml | \
-for job in `echo $jobs | tr "\n" " "`; do
+for job in $(echo "$jobs" | tr "\n" " "); do
echo "Deleting $job"
curl -X POST "https://$username:$password@jenkins.opendaylight.org/$system/job/${job}/doDelete"
done
echo "Deleting $job"
curl -X POST "https://$username:$password@jenkins.opendaylight.org/$system/job/${job}/doDelete"
done
replace_string=$2
echo -n "Enter system (sandbox|releng): "
replace_string=$2
echo -n "Enter system (sandbox|releng): "
echo -n "Enter username: "
echo -n "Enter username: "
echo -n "Enter api_token: "
echo -n "Enter api_token: "
-echo $username:$password
+echo "$username:$password"
-wget -O jenkins-jobs.xml https://jenkins.opendaylight.org/$system/api/xml
+wget -O jenkins-jobs.xml "https://jenkins.opendaylight.org/$system/api/xml"
-jobs=`xmlstarlet sel -t -m '//hudson/job' \
+jobs=$(xmlstarlet sel -t -m '//hudson/job' \
-n -v 'name' jenkins-jobs.xml | \
-n -v 'name' jenkins-jobs.xml | \
-for job in `echo $jobs | tr "\n" " "`; do
- new_job=`echo $job | sed -e "s/${search_string}/${replace_string}/"`
+for job in $(echo "$jobs" | tr "\n" " "); do
+ new_job="${job//$search_string/$replace_string}"
echo "Renaming $job to $new_job"
echo "Renaming $job to $new_job"
- curl --data "newName=${new_job}" "https://$username:$password@jenkins.opendaylight.org/$system/job/${job}/doRename"
+ #curl --data "newName=${new_job}" "https://$username:$password@jenkins.opendaylight.org/$system/job/${job}/doRename"