This adds a few aesthetic improvements, killing some superfluous
operations.
Change-Id: Ibd4c45c9e5df91852fc7aa392ba34d3fd0c3fb52
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
implements DOMSchemaService, SchemaContextProvider, DOMYangTextSourceProvider, AutoCloseable {
private static final Logger LOG = LoggerFactory.getLogger(ScanningSchemaServiceProvider.class);
implements DOMSchemaService, SchemaContextProvider, DOMYangTextSourceProvider, AutoCloseable {
private static final Logger LOG = LoggerFactory.getLogger(ScanningSchemaServiceProvider.class);
+ private final YangTextSchemaContextResolver contextResolver = YangTextSchemaContextResolver.create("global-bundle");
- private final ListenerRegistry<SchemaContextListener> listeners = new ListenerRegistry<>();
+ private final ListenerRegistry<SchemaContextListener> listeners = ListenerRegistry.create();
private final Object lock = new Object();
private final Object lock = new Object();
- private final YangTextSchemaContextResolver contextResolver = YangTextSchemaContextResolver.create("global-bundle");
public void tryToUpdateSchemaContext() {
synchronized (lock) {
public void tryToUpdateSchemaContext() {
synchronized (lock) {
}
public boolean hasListeners() {
}
public boolean hasListeners() {
- if (Iterables.size(listeners.getListeners()) > 0) {
- hasListeners = true;
- } else {
- hasListeners = false;
- }
+ return !Iterables.isEmpty(listeners.getListeners());
public ListenerRegistration<SchemaContextListener>
registerSchemaContextListener(final SchemaContextListener listener) {
synchronized (lock) {
public ListenerRegistration<SchemaContextListener>
registerSchemaContextListener(final SchemaContextListener listener) {
synchronized (lock) {
- final Optional<SchemaContext> potentialCtx = contextResolver.getSchemaContext();
- if (potentialCtx.isPresent()) {
- listener.onGlobalContextUpdated(potentialCtx.get());
- }
+ contextResolver.getSchemaContext().ifPresent(listener::onGlobalContextUpdated);
return listeners.register(listener);
}
}
return listeners.register(listener);
}
}
@Override
public void close() {
synchronized (lock) {
@Override
public void close() {
synchronized (lock) {
- for (final ListenerRegistration<SchemaContextListener> registration : listeners) {
- registration.close();
- }
+ listeners.forEach(ListenerRegistration::close);