summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
7d83179)
Use Futures.immediateFuture(), but mark a FIXME, where we should really
be getting a response.
Change-Id: I73e1f1620df83b76d266ed8980d86bb40634a614
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
import akka.pattern.AskTimeoutException;
import akka.pattern.Patterns;
import akka.util.Timeout;
import akka.pattern.AskTimeoutException;
import akka.pattern.Patterns;
import akka.util.Timeout;
+import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.SettableFuture;
import java.util.ArrayList;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.SettableFuture;
import java.util.ArrayList;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
-import org.eclipse.jdt.annotation.NonNull;
import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
import org.opendaylight.mdsal.common.api.ReadFailedException;
import org.opendaylight.mdsal.dom.api.DOMRpcResult;
import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
import org.opendaylight.mdsal.common.api.ReadFailedException;
import org.opendaylight.mdsal.dom.api.DOMRpcResult;
- public @NonNull Object getDeviceId() {
+ public Object getDeviceId() {
? NetconfTopologyUtils.createMasterIsDownException(id, (Exception) failure) : failure;
}
? NetconfTopologyUtils.createMasterIsDownException(id, (Exception) failure) : failure;
}
- private ListenableFuture<? extends DOMRpcResult> createResult() {
- final SettableFuture<DOMRpcResult> settableFuture = SettableFuture.create();
- settableFuture.set(new DefaultDOMRpcResult());
- return settableFuture;
+ // FIXME: this is being used in contexts where we should be waiting for a reply
+ private static ListenableFuture<? extends DOMRpcResult> createResult() {
+ return Futures.immediateFuture(new DefaultDOMRpcResult());
}
private static DOMRpcResult mapInvokeRpcMessageReplyToDOMRpcResult(final InvokeRpcMessageReply reply) {
}
private static DOMRpcResult mapInvokeRpcMessageReplyToDOMRpcResult(final InvokeRpcMessageReply reply) {