summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
52ff51d)
Remove unneeded throws declaration, @Before instantiation and use of
mockito internals.
Change-Id: I7831f67d408c45582f1d97e8e21719700847b08d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
699f38ff6723788eeb1a43bc0c536f9c018c8417)
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
package org.opendaylight.netconf.api.messages;
import static org.junit.Assert.assertEquals;
package org.opendaylight.netconf.api.messages;
import static org.junit.Assert.assertEquals;
-import org.junit.Before;
import org.junit.Test;
public class NetconfHelloMessageAdditionalHeaderTest {
import org.junit.Test;
public class NetconfHelloMessageAdditionalHeaderTest {
-
-
- private String customHeader = "[user;1.1.1.1:40;tcp;client;]";
- private NetconfHelloMessageAdditionalHeader header;
-
- @Before
- public void setUp() throws Exception {
- header = new NetconfHelloMessageAdditionalHeader("user", "1.1.1.1", "40", "tcp", "client");
- }
+ private final NetconfHelloMessageAdditionalHeader header =
+ new NetconfHelloMessageAdditionalHeader("user", "1.1.1.1", "40", "tcp", "client");
- public void testGetters() throws Exception {
+ public void testGetters() {
assertEquals(header.getAddress(), "1.1.1.1");
assertEquals(header.getUserName(), "user");
assertEquals(header.getPort(), "40");
assertEquals(header.getAddress(), "1.1.1.1");
assertEquals(header.getUserName(), "user");
assertEquals(header.getPort(), "40");
- public void testStaticConstructor() throws Exception {
- NetconfHelloMessageAdditionalHeader hdr = NetconfHelloMessageAdditionalHeader.fromString(customHeader);
- assertEquals(hdr.toString(), this.header.toString());
- assertEquals(hdr.toFormattedString(), this.header.toFormattedString());
+ public void testStaticConstructor() {
+ final var hdr = NetconfHelloMessageAdditionalHeader.fromString("[user;1.1.1.1:40;tcp;client;]");
+ assertEquals(hdr.toString(), header.toString());
+ assertEquals(hdr.toFormattedString(), header.toFormattedString());
import java.util.Optional;
import java.util.Set;
import java.util.Optional;
import java.util.Set;
-import org.junit.Before;
-import org.mockito.internal.util.collections.Sets;
import org.opendaylight.netconf.api.NetconfDocumentedException;
public class NetconfHelloMessageTest {
import org.opendaylight.netconf.api.NetconfDocumentedException;
public class NetconfHelloMessageTest {
-
- Set<String> caps;
-
- @Before
- public void setUp() {
- caps = Sets.newSet("cap1");
- }
+ private final Set<String> caps = Set.of("cap1");
@Test
public void testConstructor() throws NetconfDocumentedException {
@Test
public void testConstructor() throws NetconfDocumentedException {
- NetconfHelloMessageAdditionalHeader additionalHeader = new NetconfHelloMessageAdditionalHeader("name",
- "host", "1", "transp", "id");
- NetconfHelloMessage message = NetconfHelloMessage.createClientHello(caps, Optional.of(additionalHeader));
+ var additionalHeader = new NetconfHelloMessageAdditionalHeader("name", "host", "1", "transp", "id");
+ var message = NetconfHelloMessage.createClientHello(caps, Optional.of(additionalHeader));
assertTrue(NetconfHelloMessage.isHelloMessage(message));
assertEquals(Optional.of(additionalHeader), message.getAdditionalHeader());
assertTrue(NetconfHelloMessage.isHelloMessage(message));
assertEquals(Optional.of(additionalHeader), message.getAdditionalHeader());
- NetconfHelloMessage serverMessage = NetconfHelloMessage.createServerHello(caps, 100L);
+ var serverMessage = NetconfHelloMessage.createServerHello(caps, 100L);
assertTrue(NetconfHelloMessage.isHelloMessage(serverMessage));
}
}
assertTrue(NetconfHelloMessage.isHelloMessage(serverMessage));
}
}