summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
3dc6189)
Change-Id: I1450116d13f9381d04c01f6a4b4f46a1b840cd9e
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
// FIXME: do not perform a copy, just set the limit here.
final String address = percentPos == -1 ? ipv6Address : ipv6Address.substring(0, percentPos);
// FIXME: do not perform a copy, just set the limit here.
final String address = percentPos == -1 ? ipv6Address : ipv6Address.substring(0, percentPos);
- // FIXME: fixme: use address.charAt() instead
- char[] src = address.toCharArray();
-
/* Leading :: requires some special handling. */
int i = 0;
/* Leading :: requires some special handling. */
int i = 0;
- if (src[i] == ':') {
- Preconditions.checkArgument(src[++i] == ':', "Invalid v6 address '%s'", ipv6Address);
+ if (address.charAt(i) == ':') {
+ // Note ++i side-effect in check
+ Preconditions.checkArgument(address.charAt(++i) == ':', "Invalid v6 address '%s'", ipv6Address);
}
final byte[] dst = new byte[INADDR6SZ];
}
final byte[] dst = new byte[INADDR6SZ];
- final int src_length = src.length;
+ final int src_length = address.length();
boolean saw_xdigit = false;
int val = 0;
int colonp = -1;
int j = 0;
int curtok = i;
while (i < src_length) {
boolean saw_xdigit = false;
int val = 0;
int colonp = -1;
int j = 0;
int curtok = i;
while (i < src_length) {
- final char ch = src[i++];
+ final char ch = address.charAt(i++);
/* v6 separator */
if (ch == ':') {
/* v6 separator */
if (ch == ':') {